[script][bescort]shard thief guild update

[desertkaz]

Handle the case where password is not required due to a recent visit

---

Important

Update enter_thief_guild in Bescort class to conditionally say password based on door response, handling cases where it's not needed.

• Behavior:
  • Update enter_thief_guild in Bescort class to handle cases where password is not required.
  • Only say password if door slit opens after knocking, indicating a password is needed.
• Misc:
  • Modify enter_thief_guild to use regex for response matching.

^{This description was created by for 02f207a. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 02f207a in 33 seconds. Click for details.

• Reviewed 17 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. bescort.lic:2123

• Draft comment:
  Ensure unexpected responses from knock are handled. Currently, if the knock output doesn’t match the expected regex, no password command is sent. Consider logging or adding an else clause for clarity.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50% None

Workflow ID: wflow_XEzaADsvknRCkgzs

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[MahtraDR]

Could you add us a case for when you get the password wrong? Maybe edit the script with a DRC.message saying "fix yer yaml ye grub! Yer password is wrong!" Or something like that?

[desertkaz]