Allow wildcard matching of service account subject #8629
+208
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Example: eksctl create iamserviceaccount \
--name crossplane \
--namespace crossplane-system \
--cluster "$CLUSTER_NAME" \
--role-name "$ROLE_NAME" \
--attach-policy-arn 'arn:aws:iam::aws:policy/AdministratorAccess' \
--subject-pattern 'provider-aws-*' \
--role-only \
--approve |
avoidik
changed the title
Contributor
NicholasBlaskey
left a comment
NicholasBlaskey
left a comment
There was a problem hiding this comment.
Feature looks reasonable to me. Thanks for contributing a fix
Implementation looks good to me just have a comment couples
| // instead of the service account name, and StringLike is used instead of StringEquals | ||
| // to allow wildcard matching. This only works when using command line flags (not with config files). | ||
| // +optional | ||
| SubjectPattern string `json:"-"` |
Contributor
There was a problem hiding this comment.
Is there a reason we can't support this for config too?
| // MakeAssumeRolePolicyDocumentWithServiceAccountConditionsAllowingWildcard constructs a trust policy document | ||
| // that allows wildcard pattern matching in the subject condition. The subjectPattern should be in the format | ||
| // "system:serviceaccount:namespace:name-pattern" where name-pattern can include wildcards like "*". | ||
| func (m *OpenIDConnectManager) MakeAssumeRolePolicyDocumentWithServiceAccountConditionsAllowingWildcard(serviceAccountNamespace, subjectPattern string) cft.MapOfInterfaces { |
Contributor
There was a problem hiding this comment.
Could we update MakeAssumeRolePolicyDocumentWithServiceAccountConditions to take subjectPattern instead of creating another function to avoid duplicating some of the logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
--subject-patterntoeksctl create iamserviceaccount.#8628
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯