Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: added a display name for loading #31

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OlgaYasn
Copy link

@OlgaYasn OlgaYasn commented Nov 7, 2024

Pull Request Template

✨ Title

[FIX]: added a display name for loading

πŸ“„ Description

I noticed an error message for this part of code loading: () => <VitalityLoader /> saying "Component definition is missing display name" and I tried to fix it.

βœ… Checklist

  • I have read and followed the Contribution Guide.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

πŸ”— Contextual Links (optional)

Add any relevant links to tracking tickets, previous discussions, or other resources.

πŸ“Έ Visuals (optional)

If possible, include images or videos that show the result of your changes.

πŸ” Reviewers

Please assign at least one reviewer for this PR. The PR cannot be merged until it is approved by the reviewer(s).

@OlgaYasn OlgaYasn added the WIP Work in progress label Nov 7, 2024
@OlgaYasn OlgaYasn self-assigned this Nov 7, 2024
@OlgaYasn OlgaYasn force-pushed the fix/NO-ISSUE/display-name-problem branch from 0d282aa to 64b06a9 Compare November 7, 2024 15:41
@OlgaYasn OlgaYasn marked this pull request as draft November 7, 2024 15:42
@OlgaYasn OlgaYasn removed the request for review from helabenkhalfallah November 7, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant