Conversation
|
TODO: fix github-action for release and changelog. |
|
Thank @Nico385412 for all the reviews! |
| "winston": "3.18.3" | ||
| }, | ||
| "optionalDependencies": { | ||
| "@tduyng/prettyoutput": "2.x" |
There was a problem hiding this comment.
Why put this dependancy in optionalDependencies ?
There was a problem hiding this comment.
The pretty feature is optional and mainly intended for local development and easier debugging.
In production, logs are emitted in JSON format.
The pretty formatter is therefore declared as an optional dependency. Users are free to use @tduyng/prettyoutput or provide their own implementation, or disable pretty logging entirely. This keeps the setup flexible and avoids imposing a specific formatter.
| "examples-esm": "./examples/esm/exec.sh", | ||
| "examples-cjs": "./examples/cjs/exec.sh", | ||
| "benchmark": "node ./benchmarks/basic.js", | ||
| "postinstall": "git config core.hooksPath ./.githooks || true" |
There was a problem hiding this comment.
Since this modify the user git config for the repo, maybe we should add this script as a step on the readme instead of running it automatically ?
What do you think ?
There was a problem hiding this comment.
Yes, added. Thank for your suggestion @atacanjacques
3 participants
Summary
Rewrite @ekino/logger for v3.0
Motivation
What has changed?
Here are the key changes made in this PR:
Test plan
Also close issue #25 , close issue #37