Fix status check not working for PRs without any status checks #405
+17
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github GraphQL response returns null for the StatusCheckRollup object if there are no status checks at all. In that case, this should be a pass.
From my understanding, spr gets the state of the PullRequest with a graphql query like the following:
On the repository I am working on, this would give a response with a
statusCheckRollup: null
:This prevented me from merging PRs in the stack as the status check would always fail. This fix makes null statusCheckRollups a pass instead.
I rebuilt this executable locally and was able to move my PRs along with no issue.