Add Cell tests and fix hash randomisation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Games::TMX::Parser::Cell objects relied on a consistent hash key order, which is no longer guarranteed after Perl 5.12. This reimplements the seek_next_cell method so it will continue to work on newer versions of Perl, and adds tests for that and other Cell methods, which were not being covered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Games::TMX::Parser::Cell objects relied on a consistent hash key order, which is no longer guarranteed after Perl 5.18.
This reimplements the seek_next_cell method so it will continue to work on newer versions of Perl, and adds tests for that and other Cell methods, which were not being covered.