Add support for TSX files through parsefile method for Maps and TileSets #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a
parsefilemethod for both Map and TileSet objects that allows them to read TMX and TSX files respectively. It also makes changes to the way the Map class instantiates its children TileSets, by detecting when the tileset needs to be read from an external (source) file, and does the right thing.I've included some tests files, and some tests.
It does not include any documentation changes, since this change should be transparent to users, and users are not currently allowed to instantiate their own TileSet objects.
Since TileSet objects will also reference files (eg. the image file), this change adds a
root_dirto both Map and TileSet classes so they know where to load these files from. This is inherited from themap_dirattribute of the parent Parser object.