Merge pull request #53 from eigr/fix/memory-leak

Reduces an Actor's memory usage
eigr · Sep 16, 2022 · f9cf4fc · f9cf4fc
2 parents 2e64b09 + 6d0449f
commit f9cf4fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/apps/actors/lib/actors/actor/entity.ex b/apps/actors/lib/actors/actor/entity.ex
@@ -9,7 +9,6 @@ defmodule Actors.Actor.Entity do
     ActorDeactivateStrategy,
     ActorState,
     ActorSnapshotStrategy,
-    ActorSystem,
     TimeoutStrategy
   }
 
@@ -34,7 +33,7 @@ defmodule Actors.Actor.Entity do
             state_hash: state_hash
           }
 
-    @type t :: %EntityState{system: ActorSystem.t(), actor: Actor.t(), state_hash: binary()}
+    @type t :: %EntityState{system: String.t(), actor: Actor.t(), state_hash: binary()}
   end
 
   @impl true
@@ -201,7 +200,7 @@ defmodule Actors.Actor.Entity do
          } = _invocation},
         _from,
         %EntityState{
-          system: %ActorSystem{name: actor_system} = _system,
+          system: actor_system,
           actor: %Actor{state: current_state = _actor_state} = _state_actor
         } = state
       )
@@ -260,7 +259,7 @@ defmodule Actors.Actor.Entity do
          } = _invocation},
         _from,
         %EntityState{
-          system: %ActorSystem{name: actor_system} = _system,
+          system: actor_system,
           actor: %Actor{state: %ActorState{state: current_state} = _actor_state} = _state_actor
         } = state
       ) do

diff --git a/apps/actors/lib/actors/actor/entity_supervisor.ex b/apps/actors/lib/actors/actor/entity_supervisor.ex
@@ -29,7 +29,7 @@ defmodule Actors.Actor.Entity.Supervisor do
   Adds a Actor to the dynamic supervisor.
   """
   @spec lookup_or_create_actor(ActorSystem.t(), Actor.t()) :: {:ok, any}
-  def lookup_or_create_actor(actor_system, %Actor{} = actor) do
+  def lookup_or_create_actor(%ActorSystem{name: actor_system} = system, %Actor{} = actor) do
     entity_state = %EntityState{system: actor_system, actor: actor}
 
     child_spec = %{