-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage-provider-server): add p2p bootstrap and registration #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
th7nder
requested changes
Jan 7, 2025
aidan46
force-pushed
the
feat/peer-resolver
branch
from
January 7, 2025 12:40
13fb051
to
a3e3803
Compare
jmg-duarte
reviewed
Jan 9, 2025
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jan 10, 2025
th7nder
previously requested changes
Jan 10, 2025
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jan 13, 2025
aidan46
force-pushed
the
feat/peer-resolver
branch
from
January 14, 2025 09:21
b246518
to
2044170
Compare
Add P2P bootstrap and register behaviour to the polka-storage-provider-server.
jmg-duarte
changed the title
feat: Add P2P functionality
feat(storage-provider-server): add p2p bootstrap and registration
Jan 14, 2025
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jan 15, 2025
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jan 15, 2025
jmg-duarte
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I've left some comments that require addressing, others for discussion
cernicc
reviewed
Jan 15, 2025
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jan 15, 2025
jmg-duarte
approved these changes
Jan 16, 2025
cernicc
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds bootstrap and registration p2p node functionality to the polka-storage-provider-server. The node type is selected by passing the node-type argument into the CLI (bootstrap or registration). Configuration is read from a TOML file, see the example in the p2p-example-config folder. The P2P network supports an ED25519 private key in PEM file format.
The
generate-peer-id
command has been added to the polka-storage-provider-client. This command generates a peer ID from an ED25519 public key PEM file and writes it to a file or stdout, depending on the--file
argument.Note:
I have not added any P2P discovery, this will be implemented in the fetching application. I can add a discovery example if needed.