Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partially reverted cases handling #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix partially reverted cases handling #4

wants to merge 1 commit into from

Conversation

eval-exec
Copy link
Contributor

eval-exec
eval-exec commented Jul 18, 2022
View reviewed changes
eth/tracers/native/types.go Outdated
}

func (t *OpsTracer) Stop(err error) {
t.reason = err
t.callstack.Error = err.Error()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cannium Stop() 是 bsc 特有的方法，只有当 tracer timeout 发生时，才会调用 Stop()

cannium
cannium reviewed Jul 18, 2022
View reviewed changes
eth/tracers/native/types.go Outdated
}

func (t *OpsTracer) Stop(err error) {
t.reason = err
t.callstack.Error = err.Error()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err.Error()需要判空吗

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外需要把callstack.Calls置空吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cannium cannium cannium left review comments

@hitdavid hitdavid Awaiting requested review from hitdavid

@yuanhongda yuanhongda Awaiting requested review from yuanhongda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @cannium