Code

Realistic BTOF digitization#1635

Code

Open

ssedd1123 wants to merge 119 commits intomaineic/EICrecon:mainfrom pr/BTOF-digitization-clusterizationeic/EICrecon:pr/BTOF-digitization-clusterizationCopy head branch name to clipboard

+1,151-70

Commits

Commits on Jul 18, 2024

• First commit of BTOF digitization code!

  ssedd1123

  committed
  8123783

  Copy full SHA for 8123783

Commits on Jul 19, 2024

• Update BTOFHitDigi.cc

  eicsouvik

  authored
  2332d18

  Copy full SHA for 2332d18

• Update BTOFHitDigi.h

  eicsouvik

  authored
  4b907cb

  Copy full SHA for 4b907cb

• Update BTOFHitDigi.cc

  eicsouvik

  authored
  204d472

  Copy full SHA for 204d472

• Merge pull request #3 from eicsouvik/patch-1

  Show description for 1b08022
  ssedd1123

  authored
  1b08022

  Copy full SHA for 1b08022

• Merge pull request #2 from eicsouvik/patch-2

  Show description for 5e011e1
  ssedd1123

  authored
  5e011e1

  Copy full SHA for 5e011e1

• Merge pull request #1 from eicsouvik/patch-3

  Show description for 5e17954
  ssedd1123

  authored
  5e17954

  Copy full SHA for 5e17954

• Changed the algorithm of BarrelTOFNeighborFinder so it's more intuitative.

  

  Desktop ssedd1123

  authored and

  Desktop ssedd1123

  committed
  9fbe640

  Copy full SHA for 9fbe640

• Merge branch 'main' of https://github.com/ssedd1123/EICrecon

  

  Desktop ssedd1123

  authored and

  Desktop ssedd1123

  committed
  171ffd4

  Copy full SHA for 171ffd4

• Changed spread calculation. Originally the spread were estimated with distance relative to the center of the center cell. Now it's changed so spread is calculated relative to the true hit location.

  

  Desktop ssedd1123

  authored and

  Desktop ssedd1123

  committed
  52a9b33

  Copy full SHA for 52a9b33

Commits on Jul 25, 2024

• Fixed bugs when sensor ID from barrelTOFNeighborFinder gives wrong neighbors when cell ID from BitFieldDecoder for cellID is negative.

  ssedd1123

  committed
  54024b6

  Copy full SHA for 54024b6

Commits on Aug 3, 2024

• Merge branch 'eic:main' into main

  ssedd1123

  authored
  5e1cec4

  Copy full SHA for 5e1cec4

• Updated BTOF neighbor finder. To be used with updated epic geometry with dead spaces implemented.

  ssedd1123

  committed
  40abca0

  Copy full SHA for 40abca0

Commits on Aug 26, 2024

• Merge branch 'eic:main' into main

  ssedd1123

  authored
  72edf8b

  Copy full SHA for 72edf8b

• Merge branch 'eic:main' into main

  ssedd1123

  authored
  df48d16

  Copy full SHA for df48d16

• Merge branch 'eic:main' into main

  ssedd1123

  authored
  1d3c040

  Copy full SHA for 1d3c040

Commits on Sep 24, 2024

• Sync fork.

  ssedd1123

  committed
  1adfd02

  Copy full SHA for 1adfd02

• Added missing closing parenthesis.

  ssedd1123

  committed
  f373972

  Copy full SHA for f373972

Commits on Sep 27, 2024

• Use more realistic charge sharing parameters and bug fix on ADC heights.

  ssedd1123

  committed
  0725492

  Copy full SHA for 0725492

• Merge branch 'main' of https://github.com/ssedd1123/EICrecon

  ssedd1123

  committed
  a451aed

  Copy full SHA for a451aed

Commits on Oct 8, 2024

• Fixed incorrect threshold for ADC TDC.

  ssedd1123

  committed
  ce9122d

  Copy full SHA for ce9122d

Commits on Oct 14, 2024

• Merge branch 'eic:main' into main

  ssedd1123

  authored
  08c83e6

  Copy full SHA for 08c83e6

Commits on Oct 15, 2024

• Move digitization code to the main branch.

  ssedd1123

  committed
  350ca3b

  Copy full SHA for 350ca3b

• Formated files.

  ssedd1123

  committed
  4f892ee

  Copy full SHA for 4f892ee

• Included config content in parameter ref.

  ssedd1123

  committed
  8d8a12a

  Copy full SHA for 8d8a12a

• Merge remote-tracking branch 'new-origin/main' into pr/BTOF-digitization-clusterization

  ssedd1123

  committed
  d260635

  Copy full SHA for d260635

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 875f0f4
  pre-commit-ci[bot]

  committed
  875f0f4

  Copy full SHA for 875f0f4

• Fixed BTOF reco uncertainty estimation bug.

  ssedd1123

  committed
  b12ee38

  Copy full SHA for b12ee38

Commits on Oct 21, 2024

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  0d91db5

  Copy full SHA for 0d91db5

Commits on Oct 23, 2024

• Removed reconstruction for later pull request. Breaks TOF digi into three parts: 1. Charge sharing, 2. Pulse generation, 3. Pulse digitization.

  ssedd1123

  committed
  34f4daa

  Copy full SHA for 34f4daa

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 9ab01c9
  pre-commit-ci[bot]

  committed
  9ab01c9

  Copy full SHA for 9ab01c9

• Removed legacy modification to JEventProcessorPODIO.cc

  ssedd1123

  committed
  4cf1216

  Copy full SHA for 4cf1216

• Merge branch 'pr/BTOF-digitization-clusterization' of https://github.com/eic/EICrecon into pr/BTOF-digitization-clusterization

  ssedd1123

  committed
  83c9b88

  Copy full SHA for 83c9b88

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  deaf63c

  Copy full SHA for deaf63c

• Fixed bugs on charge sharing calculation. It was assumed that all geant hits on BTOF occurs at the center of a BTOF cell. That may not be true. It has been fixed.

  ssedd1123

  committed
  14889de

  Copy full SHA for 14889de

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  7474a52

  Copy full SHA for 7474a52

• Moved algorithms away from src/detectors.

  ssedd1123

  committed
  569090d

  Copy full SHA for 569090d

Commits on Oct 24, 2024

• Fix spelling mistakes to make codespell happy.

  ssedd1123

  committed
  33c6587

  Copy full SHA for 33c6587

Commits on Oct 25, 2024

• Removed unnecessary header files.

  ssedd1123

  committed
  b28d49f

  Copy full SHA for b28d49f

• Trigger Build

  ssedd1123

  committed
  8f01587

  Copy full SHA for 8f01587

Commits on Nov 1, 2024

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  595952d

  Copy full SHA for 595952d

• Update src/algorithms/digi/BTOFChargeSharing.cc

  Show description for a4b5211
  

  ssedd1123

  and

  veprbl

  authored
  a4b5211

  Copy full SHA for a4b5211

• Update src/algorithms/digi/TOFPulseDigitization.cc

  Show description for f4f3204
  

  ssedd1123

  and

  veprbl

  authored
  f4f3204

  Copy full SHA for f4f3204

• Update src/algorithms/digi/TOFPulseDigitization.cc

  Show description for 76fccd8
  

  ssedd1123

  and

  veprbl

  authored
  76fccd8

  Copy full SHA for 76fccd8

• Update src/algorithms/digi/BTOFChargeSharing.cc

  Show description for 310c510
  

  ssedd1123

  and

  veprbl

  authored
  310c510

  Copy full SHA for 310c510

• Update src/algorithms/digi/TOFPulseDigitization.h

  Show description for 6e44318
  

  ssedd1123

  and

  veprbl

  authored
  6e44318

  Copy full SHA for 6e44318

• Update src/algorithms/digi/TOFPulseGeneration.h

  Show description for 7ecc458
  

  ssedd1123

  and

  veprbl

  authored
  7ecc458

  Copy full SHA for 7ecc458

• Update src/algorithms/digi/BTOFChargeSharing.cc

  Show description for 41614b8
  

  ssedd1123

  and

  veprbl

  authored
  41614b8

  Copy full SHA for 41614b8

• Update src/algorithms/digi/BTOFChargeSharing.h

  Show description for 7ca28d3
  

  ssedd1123

  and

  veprbl

  authored
  7ca28d3

  Copy full SHA for 7ca28d3

• Update src/algorithms/digi/BTOFChargeSharing.cc

  Show description for 576055c
  

  ssedd1123

  and

  veprbl

  authored
  576055c

  Copy full SHA for 576055c

• Replaced magic number in BTOFChargeSharing with the correct unit.

  ssedd1123

  committed
  232a3ef

  Copy full SHA for 232a3ef

• Make clang-tidy-iwyu happy.

  ssedd1123

  committed
  8043bff

  Copy full SHA for 8043bff

Commits on Nov 2, 2024

• Trigger Build

  ssedd1123

  committed
  837900a

  Copy full SHA for 837900a

• Update src/algorithms/digi/TOFPulseGeneration.cc

  Show description for e51c007
  

  ssedd1123

  and

  veprbl

  authored
  e51c007

  Copy full SHA for e51c007

• Update src/algorithms/digi/TOFPulseGeneration.cc

  Show description for 1d3f592
  

  ssedd1123

  and

  veprbl

  authored
  1d3f592

  Copy full SHA for 1d3f592

• Make clang-tidy-iwyu happy.

  ssedd1123

  committed
  3e0afdc

  Copy full SHA for 3e0afdc

Commits on Nov 4, 2024

• TOFPulseGeneration_factory.h: mixedCase for parameter names

  veprbl

  authored
  89452f4

  Copy full SHA for 89452f4

• TOFPulseDigitization_factory.h: ditto

  veprbl

  authored
  d0040c6

  Copy full SHA for d0040c6

• TOFPulseDigitization_factory.h: missed

  veprbl

  authored
  bbc6ab0

  Copy full SHA for bbc6ab0

• BTOFChargeSharing_factory.h: ditto

  veprbl

  authored
  5664496

  Copy full SHA for 5664496

• TOFHitDigiConfig.h: rm unused suff

  veprbl

  authored
  00d1890

  Copy full SHA for 00d1890

• BTOFChargeSharing_factory.h: need algorithmsInit

  veprbl

  authored
  3af27a9

  Copy full SHA for 3af27a9

• TOFPulseDigitization_factory.h: ditto

  veprbl

  authored
  cb3209d

  Copy full SHA for cb3209d

• TOFPulseGeneration_factory.h: ditto

  veprbl

  authored
  6ba7bab

  Copy full SHA for 6ba7bab

• BTOFChargeSharing.h: remove cache stuff for now

  veprbl

  authored
  fa7ad55

  Copy full SHA for fa7ad55

Commits on Nov 5, 2024

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  veprbl

  authored
  5f092d4

  Copy full SHA for 5f092d4

• JEventProcessorPODIO.cc: add TOFBarrelADCTDC

  veprbl

  authored
  ef00944

  Copy full SHA for ef00944

• Update src/services/io/podio/JEventProcessorPODIO.cc

  veprbl

  authored
  a745e2b

  Copy full SHA for a745e2b

Commits on Nov 7, 2024

• Added tests for TOFPulseDigitization and TOFPulseGeneration.

  ssedd1123

  committed
  dd95d6b

  Copy full SHA for dd95d6b

• Removed unnecessary credits.

  ssedd1123

  committed
  d073d6b

  Copy full SHA for d073d6b

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 6e34d8a
  pre-commit-ci[bot]

  committed
  6e34d8a

  Copy full SHA for 6e34d8a

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  22c9fe4

  Copy full SHA for 22c9fe4

Commits on Nov 18, 2024

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  ce7b6a0

  Copy full SHA for ce7b6a0

Commits on Nov 21, 2024

• Update src/algorithms/digi/TOFHitDigiConfig.h

  Show description for d732550
  

  ssedd1123

  and

  ruse-traveler

  authored
  d732550

  Copy full SHA for d732550

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  aef5225

  Copy full SHA for aef5225

• Amplitude of Landau pulse is now a configurable parameter.

  ssedd1123

  committed
  40cf825

  Copy full SHA for 40cf825

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for fbde72c
  pre-commit-ci[bot]

  committed
  fbde72c

  Copy full SHA for fbde72c

Commits on Nov 22, 2024

• Beginning time of TOFPulse is now aligned to the beginning of clock cycle. Units are also added to TOFHitDigiConfig.

  ssedd1123

  committed
  da1321b

  Copy full SHA for da1321b

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 515eba4
  pre-commit-ci[bot]

  committed
  515eba4

  Copy full SHA for 515eba4

• Make clang-tidy-iwyu happy.

  ssedd1123

  committed
  fcb0e07

  Copy full SHA for fcb0e07

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  5f3d182

  Copy full SHA for 5f3d182

Commits on Nov 25, 2024

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  a1455a8

  Copy full SHA for a1455a8

• Fix typo in code.

  ssedd1123

  committed
  9551964

  Copy full SHA for 9551964

Commits on Nov 26, 2024

• Trigger Build

  ssedd1123

  committed
  3d4638c

  Copy full SHA for 3d4638c

Commits on Dec 1, 2024

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  veprbl

  authored
  99d7bd8

  Copy full SHA for 99d7bd8

• apply clang-format

  veprbl

  committed
  29239b7

  Copy full SHA for 29239b7

Commits on Dec 2, 2024

• Trigger Build

  ssedd1123

  committed
  6a67c57

  Copy full SHA for 6a67c57

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  92263ed

  Copy full SHA for 92263ed

Commits on Dec 3, 2024

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  071d7af

  Copy full SHA for 071d7af

Commits on Dec 10, 2024

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  a1ab224

  Copy full SHA for a1ab224

Commits on Dec 18, 2024

• Added extra bits to show which EIRCOR cycle a timestampe belongs to.

  ssedd1123

  committed
  b1f7166

  Copy full SHA for b1f7166

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for f31c553
  pre-commit-ci[bot]

  committed
  f31c553

  Copy full SHA for f31c553

• Separate config class for PulseDigitization and PulseGeneration.

  ssedd1123

  committed
  2981788

  Copy full SHA for 2981788

• Merge branch 'pr/BTOF-digitization-clusterization' of https://github.com/eic/EICrecon into pr/BTOF-digitization-clusterization

  ssedd1123

  committed
  3883f9b

  Copy full SHA for 3883f9b

• Make clang-tidy happy.

  ssedd1123

  committed
  9fe2773

  Copy full SHA for 9fe2773

• Modified slightly so it works with negative global time.

  ssedd1123

  committed
  2401f0a

  Copy full SHA for 2401f0a

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 01473d3
  pre-commit-ci[bot]

  committed
  01473d3

  Copy full SHA for 01473d3

• Make clang-tidy happy.

  ssedd1123

  committed
  2aab59b

  Copy full SHA for 2aab59b

Commits on Dec 20, 2024

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  d1218e0

  Copy full SHA for d1218e0

Commits on Jan 2, 2025

• Update src/algorithms/digi/LGADPulseGenerationConfig.h

  Show description for 0093690
  

  ssedd1123

  and

  ruse-traveler

  authored
  0093690

  Copy full SHA for 0093690

• Update src/algorithms/digi/LGADPulseDigitizationConfig.h

  Show description for 6f852c0
  

  ssedd1123

  and

  ruse-traveler

  authored
  6f852c0

  Copy full SHA for 6f852c0

• Update src/algorithms/digi/LGADChargeSharingConfig.h

  Show description for 231cb0a
  

  ssedd1123

  and

  ruse-traveler

  authored
  231cb0a

  Copy full SHA for 231cb0a

• Update src/algorithms/digi/LGADPulseGeneration.cc

  Show description for 7f8a8e3
  

  ssedd1123

  and

  ruse-traveler

  authored
  7f8a8e3

  Copy full SHA for 7f8a8e3

• Removed legacy file LGADChargeSharingConfig.h

  ssedd1123

  committed
  8e652c9

  Copy full SHA for 8e652c9

Commits on Jan 3, 2025

• Update src/algorithms/digi/BTOFChargeSharing.cc

  Show description for e695627
  

  ssedd1123

  and

  ruse-traveler

  authored
  e695627

  Copy full SHA for e695627

• use private rather than protected on BTOFChargeSharing

  ssedd1123

  committed
  a1aa137

  Copy full SHA for a1aa137

Commits on Jan 4, 2025

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  ssedd1123

  authored
  350d280

  Copy full SHA for 350d280

Commits on Jan 7, 2025

• Update src/algorithms/digi/LGADPulseDigitization.cc

  Show description for e9989fe
  

  ssedd1123

  and

  simonge

  authored
  e9989fe

  Copy full SHA for e9989fe

• BTOFChargeSharing -> LGADChargeSharing. The CellID fields to scan through is now a config parameter. The condition to check if 2 cells belong to the same sensor is now also a config parameter.

  ssedd1123

  committed
  542277a

  Copy full SHA for 542277a

• Merge branch 'pr/BTOF-digitization-clusterization' of https://github.com/eic/EICrecon into pr/BTOF-digitization-clusterization

  ssedd1123

  committed
  f959908

  Copy full SHA for f959908

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 018001e
  pre-commit-ci[bot]

  committed
  018001e

  Copy full SHA for 018001e

• make clang-tidy-iwyu happy.

  ssedd1123

  committed
  e761e0d

  Copy full SHA for e761e0d

• Merge branch 'pr/BTOF-digitization-clusterization' of https://github.com/eic/EICrecon into pr/BTOF-digitization-clusterization

  ssedd1123

  committed
  57de8af

  Copy full SHA for 57de8af

Commits on Jan 8, 2025

• LGADPulseDigitization: add some missing std:: namespaces

  Show description for ab5b497
  veprbl

  authored
  ab5b497

  Copy full SHA for ab5b497

• algorithms/digi: link to algorithms for use of GeoSvc

  veprbl

  committed
  8dd1c87

  Copy full SHA for 8dd1c87

• eicrecon: load evaluator before acts (acts depends on algorithms_digi, algorithms_digi depends on evaluator)

  veprbl

  committed
  e6f1517

  Copy full SHA for e6f1517

Commits on Feb 3, 2025

• move PulseShape to become a private API

  veprbl

  committed
  09a2899

  Copy full SHA for 09a2899

• IWYU

  veprbl

  committed
  4076dbd

  Copy full SHA for 4076dbd

• Merge branch 'main' into pr/BTOF-digitization-clusterization

  veprbl

  authored
  46c5c9f

  Copy full SHA for 46c5c9f