Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs #243

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

tabs #243

wants to merge 3 commits into from

Conversation

janat08
Copy link

@janat08 janat08 commented Jun 13, 2019

@janat08
Copy link
Author

janat08 commented Jun 15, 2019

I fixed markdown not working.

@janat08
Copy link
Author

janat08 commented Nov 18, 2019

Please merge and reward

@janat08
Copy link
Author

janat08 commented Dec 6, 2019

@egoist?

@janat08
Copy link
Author

janat08 commented Dec 26, 2019

@egoist

@janat08
Copy link
Author

janat08 commented Feb 12, 2020

@egoist wouldn't mind just the bounty, pr review whenever you feel like it. It's been half a year.

@egoist
Copy link
Owner

egoist commented Mar 24, 2020

Sorry for the late reply, I think declaring tabs like this would be better:

<tabs>
  
  <tab title="JavaScript">

  ```js
  const a = 'b'
  ```
  
  </tab>

</tabs>

@janat08
Copy link
Author

janat08 commented Jan 28, 2021

You don't think mentioning it earlier would've been better. I've implemented the extra tab options off the existing ones. If you like you can create a separate issue for that, and just work off my pr. I don't think I ever got paid for any of PRs I created on your repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants