-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export createAnonymousContext define #5388
Conversation
WalkthroughThe changes update how application contexts handle a response’s realStatus. The commit adds a getter and setter for the realStatus property in the Context interface, enabling direct access through the response object. Additionally, the method runInAnonymousContextScope was removed from the Application class and reintroduced in the EggApplicationCore class with an updated signature and export in the EggCore interface. Test definitions were also updated to reflect these changes by shifting from Application to EggCore and including explicit type checks for realStatus. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant EggAppCore as EggApplicationCore
participant ContextCreator as createAnonymousContext
participant Storage as ctxStorage
Caller->>EggAppCore: runInAnonymousContextScope(scope, req)
EggAppCore->>ContextCreator: createAnonymousContext(req)
ContextCreator-->>EggAppCore: Return ctx
EggAppCore->>Storage: run(ctx, async callback)
Storage-->>EggAppCore: Execute scope within ctx
EggAppCore-->>Caller: Return result
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
🧰 Additional context used🪛 Biome (1.9.4)test/index.test-d.ts[error] 25-25: The assignment should not be in an expression. The use of assignments in expressions is confusing. (lint/suspicious/noAssignInExpressions) ⏰ Context from checks skipped due to timeout of 90000ms (20)
🔇 Additional comments (7)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #5388 +/- ##
==========================================
- Coverage 94.93% 92.96% -1.98%
==========================================
Files 40 40
Lines 3734 3739 +5
Branches 354 336 -18
==========================================
- Hits 3545 3476 -69
- Misses 189 263 +74 ☔ View full report in Codecov by Sentry. |
[skip ci] ## [4.0.4](v4.0.3...v4.0.4) (2025-02-02) ### Bug Fixes * export createAnonymousContext define ([#5388](#5388)) ([5d15623](5d15623))
Summary by CodeRabbit
New Features
Tests