-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cjs and esm both by tshy #26
Conversation
BREAKING CHANGE: drop Node.js < 18.19.0 support part of eggjs/egg#3644 eggjs/egg#5257
Caution Review failedThe pull request is closed. WalkthroughThis pull request makes extensive configuration updates and file reorganizations across the repository. ESLint configurations are modified to include additional rules and TypeScript support. Several GitHub Actions workflows are added, updated, or removed for CI, CodeQL analysis, and release processes. Documentation and package metadata are revised for rebranding and dependency updates. Test files, TypeScript configurations, and minor code adjustments like removing strict mode directives are also included. Changes
Sequence Diagram(s)sequenceDiagram
participant Commit as Git Commit
participant CI as CI Workflow (nodejs.yml)
participant External as External Node Test Workflow
Commit->>CI: Push/Pull Request on master
CI->>External: Trigger tests on Ubuntu, macOS, Windows (Node 18,20,22)
External-->>CI: Return test results
CI-->>Commit: Report CI status
sequenceDiagram
participant Push as Commit/Push to master
participant Release as Release Workflow (release.yml)
participant ExRelease as External Release Workflow
Push->>Release: Trigger release process
Release->>ExRelease: Execute release using NPM and Git tokens
ExRelease-->>Release: Complete release tasks
Release-->>Push: Report release outcome
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (25)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
[skip ci] ## [3.0.0](v2.2.0...v3.0.0) (2025-02-04) ### ⚠ BREAKING CHANGES * drop Node.js < 18.19.0 support part of eggjs/egg#3644 eggjs/egg#5257 ### Features * support cjs and esm both by tshy ([#26](#26)) ([52df3aa](52df3aa))
BREAKING CHANGE: drop Node.js < 18.19.0 support
part of eggjs/egg#3644
eggjs/egg#5257
Summary by CodeRabbit
Documentation
New Features
Configuration Updates