Skip to content

Conversation

@IMEVER
Copy link

@IMEVER IMEVER commented Oct 26, 2025

Use KB to log download progress,
Make the output more readable.

Use KB to log download progress
@efahl efahl closed this Nov 6, 2025
@efahl efahl reopened this Nov 6, 2025
@efahl efahl force-pushed the main branch 2 times, most recently from 33d058e to d90d2cb Compare November 6, 2025 19:08
@efahl efahl closed this Nov 6, 2025
@efahl efahl reopened this Nov 6, 2025
@efahl efahl force-pushed the main branch 2 times, most recently from 5a98ad3 to 85ef77c Compare November 6, 2025 19:24
@efahl
Copy link
Owner

efahl commented Nov 6, 2025

Sorry about all the thrashing above, I'm trying to learn github actions and you are the first victim.

In any case, the code looks fine, but could you rewrite your commit message to use the "standard" OpenWrt commit format (see https://openwrt.org/submitting-patches#submission_guidelines).

owut: change bytes to KB in progress monitor

Improve format of progress monitor so it is more readable.

Signed-off-by: name <email@address>

You can automatically add the Signed-off-by: when you do the commit by using the --signoff option:

git commit --amend --signoff

@GeorgeSapkin
Copy link

Better yet, would be having a dynamic human-readable format. Sort like what lots of CLI tools do with -h.

@efahl
Copy link
Owner

efahl commented Dec 20, 2025

Better yet, would be having a dynamic human-readable format. Sort like what lots of CLI tools do with -h.

Yup, there are lots of ways to make output prettier, but I've intentionally kept the code as small as possible so as to minimize footprint of the package. Every time I add a feature I fret over size, as the old auc was only about 30-50k total and owut is twice that now if you consider the dependencies...

@GeorgeSapkin
Copy link

Good point. I suppose theoretically there could be different variants with different features, like vim, with tiny being the default pre-installed.

@efahl
Copy link
Owner

efahl commented Dec 20, 2025

with tiny being the default pre-installed.

Oh, yeah, I've been thinking about how to do that since Hauke mentioned adding owut to defaults back in https://lists.openwrt.org/pipermail/openwrt-devel/2025-September/044253.html I see I called it owut-lite there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants