Fixed: [LVGL] False error "Invalid color" reported in Led widget when…

… expression is used for the "Color" #641
eez-open · Nov 19, 2024 · 16bb20c · 16bb20c
1 parent 0574bb6
commit 16bb20c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 14 deletions.
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
     "author": "Envox <[email protected]>",
     "description": "Cross-platform visual development tool and SCPI instrument controller",
     "homepage": "https://www.envox.hr/eez/studio/studio-introduction.html",
-    "version": "0.20.0",
+    "version": "0.21.0",
     "revision": "1",
     "license": "GPL-3.0-only",
     "repository": "https://github.com/eez-open/studio",

diff --git a/packages/project-editor/lvgl/widgets/Led.tsx b/packages/project-editor/lvgl/widgets/Led.tsx
@@ -72,19 +72,21 @@ export class LVGLLedWidget extends LVGLWidget {
         },
 
         check(object: LVGLLedWidget, messages) {
-            const colorValue = getThemedColor(
-                ProjectEditor.getProjectStore(object),
-                object.color
-            ).colorValue;
-
-            if (!isValid(colorValue)) {
-                messages.push(
-                    new Message(
-                        MessageType.ERROR,
-                        `invalid color`,
-                        getChildOfObject(object, "color")
-                    )
-                );
+            if (object.colorType == "literal") {
+                const colorValue = getThemedColor(
+                    ProjectEditor.getProjectStore(object),
+                    object.color
+                ).colorValue;
+
+                if (!isValid(colorValue)) {
+                    messages.push(
+                        new Message(
+                            MessageType.ERROR,
+                            `invalid color`,
+                            getChildOfObject(object, "color")
+                        )
+                    );
+                }
             }
         },