fix: redacting user retirement data in lms #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for tracking Jenkins build numbers when cleaning up user retirement data in the LMS. The change enables the retirement cleanup process to associate a specific Jenkins job run with the retirement records being processed.
Changes:
- Added optional
jenkins_run_idparameter to track the Jenkins BUILD_NUMBER during retirement cleanup operations - Updated the cleanup functions to pass the Jenkins run ID through to the LMS API
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tubular/scripts/retirement_archive_and_cleanup.py | Added jenkins_run_id parameter to archive_and_cleanup CLI command and _cleanup_retirements_or_exit function |
| tubular/edx_api.py | Modified bulk_cleanup_retirements method to accept and conditionally include jenkins_run_id in API request payload |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added jenkins_run_id parameter support for user retirement cleanup to enable traceability between Jenkins jobs and redacted retirement records.
Related Ticket
https://2u-internal.atlassian.net/browse/BOMS-293