chore: analytics exporter #1767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katebygrace
force-pushed
the
katebygrace/exporter-migrate
branch
5 times, most recently
from
dd73a02
to
22da28b
Compare
| # Configuration paths in analytics-secure | ||
| SECURE_ROOT=${WORKSPACE}/analytics-secure/analytics-exporter | ||
| cd analytics-config/analytics-exporter | ||
| python3 secrets-manager.py -w -n analytics-secure/analytics-exporter/task-auth.json -v task-auth.json |
There was a problem hiding this comment.
Looking at
, it looks like we also need default.yaml in addition to task-auth.jsonThere was a problem hiding this comment.
Also, I'm forgetting this but where did we decide to keep the secrets-manager.py script ?
is it going to be part of analytics-tools repo ?
There was a problem hiding this comment.
I noticed that the path here is analytics-secure/analytics-exporter/task-auth.json, shouldn't it be analytics-config ?
There was a problem hiding this comment.
Yes to analytics-tools repo. It should be in there already.
Task-auth has sensitive values, so i was going to pull it from secrets manager
katebygrace
force-pushed
the
katebygrace/exporter-migrate
branch
12 times, most recently
from
871e9d8
to
f7bd2e3
Compare
JIRA:CLOUDSEC-12
katebygrace
force-pushed
the
katebygrace/exporter-migrate
branch
from
f7bd2e3
to
3886db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:CLOUDSEC-12
would need https://github.com/edx/analytics-config/pull/3 too