feat: add a step to the stepper for academy selection and update lang… #128

mchilagani-sonata · 2025-12-27T12:26:51Z

…uage

Added an “Academy Selection” step to the stepper, including initial setup, updated language, and i18n support; this step is hidden for users who enter directly into the Teams flow.
Added the Academy Selection stepper to the essentials/academic-selection route.

…uage

codecov · 2025-12-27T12:28:42Z

Codecov Report

❌ Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.20%. Comparing base (35be22a) to head (30a9d95).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
...rc/components/Stepper/CheckoutStepperContainer.tsx	66.66%	3 Missing ⚠️
.../components/plan-details-pages/PlanDetailsPage.tsx	0.00%	3 Missing ⚠️
...onents/app/routes/loaders/checkoutStepperLoader.ts	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   84.12%   85.20%   +1.08%     
==========================================
  Files         147      149       +2     
  Lines        2444     2528      +84     
  Branches      410      482      +72     
==========================================
+ Hits         2056     2154      +98     
+ Misses        388      374      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

brobro10000

When creating the essentials feature, please keep in mind the teams feature is a complete feature and the original application behavior should not be interrupted as its release imminent.

Hide the essentials logic behind the feature flag and ensure the stepper remains a 3 step component for now until eseentials is ready to release. Please review the product requirements of the essentials page bearing in mind the following:

The essentials page is both an authenticated and unauthenticated route
The essentials page initial point of entry is from business.edx.org (external) so the stepper upcoming stepper (plan-details etc.) behavior is completely dependent on whether a user selects an academy or chooses to upgrade
The teams page initial entry point is /plan-details and the original logic should remain that if the user directly navigates to plan details with an incomplete checkout intent object the stepper flow is dependent on the product the user select (either a teams or essentials product).

I am available to pair to help get this over the line and make the requirements clear.

brobro10000 · 2026-01-08T02:56:38Z

src/components/account-details-page/tests/AccountDetailsPage.test.tsx

+      authenticatedUser: { userId: 12345 },
    });
-    validateText('Continue');
+    expect(screen.getByText('Continue')).toBeInTheDocument();


This can remain as validateText since it does essentially the same thing.

brobro10000 · 2026-01-08T02:56:44Z

src/components/account-details-page/tests/AccountDetailsPage.test.tsx

+    expect(
+      screen.getByText('What is the name of your company or organization?'),
+    ).toBeInTheDocument();


This can remain as validateText since it does essentially the same thing.

brobro10000 · 2026-01-08T02:56:51Z

src/components/account-details-page/tests/AccountDetailsPage.test.tsx

+    expect(
+      screen.getByText('Create a custom URL for your team'),
+    ).toBeInTheDocument();
+  });


This can remain as validateText since it does essentially the same thing.

brobro10000 · 2026-01-08T02:57:13Z

src/components/account-details-page/tests/AccountDetailsPage.test.tsx

+
+    fireEvent.click(screen.getByText('Back'));
+
+    // expect(screen.queryByText('Plan Details')).toBeInTheDocument();


Is this supposed to be commented out?

brobro10000 · 2026-01-08T02:58:17Z

src/components/app/routes/loaders/checkoutStepperLoader.ts

+  if (authenticatedUser) {
+    // If the user is already authenticated, redirect to AcademicSelection Page.
+    return redirect(CheckoutPageRoute.AcademicSelection);


I would retain the original logic to PlanDetails since AcademicSelection should only be navigable via business.edx.org

brobro10000 · 2026-01-08T03:11:36Z

src/components/Stepper/CheckoutStepperContainer.tsx

+
 const Steps = (): ReactElement => (
  <>
+    <AcademicSelection />


Hide behind feature flag since it is an incomplete feature. See rootloader.ts.

brobro10000 · 2026-01-08T03:12:14Z

src/i18n/ar.json

Remove this file

brobro10000 · 2026-01-08T03:12:17Z

src/i18n/en.json

Remove this file

brobro10000 · 2026-01-08T03:12:20Z

src/i18n/hi.json

Remove this file

brobro10000 · 2026-01-08T03:13:06Z

src/utils/checkout.ts

+  const { step, substep } = params;
+
+  // Essentials uses substep as the step
+  const resolvedStep = step ?? substep ?? CheckoutStepKey.AcademicSelection;
+
+  const currentStepKey = resolvedStep as CheckoutStepKey;
+
+  const currentSubstepKey = step && substep ? substep : undefined;
+
+  const currentStep = CheckoutStepByKey[currentStepKey];
+  const currentSubstep = currentSubstepKey
+    ? CheckoutSubstepByKey[currentSubstepKey]
+    : undefined;


I believe the original implementation was correct.

brobro10000 · 2026-01-08T05:00:28Z

This POC should help guide you in the right direction for how to safely integrate academic selection into the current stepper process while it being gated by a feature flag.
#133

mchilagani-sonata · 2026-01-15T14:01:44Z

This is no longer needed, as the academy selection page is being removed from the stepper flow. As noted by Alberto Del Toro and with Hamzah creating a new ticket under the new architecture, so the PR is being closed.

feat: add a step to the stepper for academy selection and update lang…

cf19366

…uage

fix(types): resolve check-types issue

ac39df5

mchilagani-sonata requested a review from brobro10000 December 29, 2025 08:51

mchilagani-sonata added 4 commits January 1, 2026 10:56

test(coverage): improve unit test coverage

723837e

test(coverage): improve unit test coverage

83dfa76

chore(lint): fix lint errors

0b045be

fix(coverage): improve unit test coverage

30a9d95

brobro10000 reviewed Jan 8, 2026

View reviewed changes

mchilagani-sonata closed this Jan 15, 2026


		fireEvent.click(screen.getByText('Back'));

		// expect(screen.queryByText('Plan Details')).toBeInTheDocument();

feat: add a step to the stepper for academy selection and update lang… #128

feat: add a step to the stepper for academy selection and update lang… #128

Uh oh!

Conversation

mchilagani-sonata commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brobro10000 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brobro10000 commented Jan 8, 2026

Uh oh!

mchilagani-sonata commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mchilagani-sonata commented Dec 27, 2025 •

edited

Loading

codecov bot commented Dec 27, 2025 •

edited

Loading