Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove manage my subscriptions CTAs #4

Merged

Conversation

julianajlk
Copy link
Member

@julianajlk julianajlk commented Jul 30, 2024

REV-4003.
Below visual changes are only applied for learners that had a subscription.

Before:
Screenshot 2024-07-29 at 2 32 14 PM

After:
Screenshot 2024-08-01 at 11 47 24 AM

This PR:

  • Remove the "Manage my subscriptions" button from the Order History page (aka Orders and Subscriptions Page)
  • Removes any fetch calls to Subscriptions service to generate the Customer Portal URL
  • Removes the ManageSubscriptionsPage that is used by Program Details Page in edx-platform to generate the URL.

Please note:

  • This PR will only be merged/deployed after the edx-platform PR to remove the CTA from the Program Details Page.

@julianajlk julianajlk requested a review from a team as a code owner July 30, 2024 19:18
@julianajlk julianajlk force-pushed the julianajlk/REV-4003/remove-subs-stripe-portal-cta branch 2 times, most recently from 0fd73d4 to d306bd2 Compare July 30, 2024 19:46
@julianajlk julianajlk force-pushed the julianajlk/REV-4003/remove-subs-stripe-portal-cta branch from d306bd2 to 1d4ab68 Compare July 30, 2024 19:52
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.37%. Comparing base (f425c4b) to head (2c5b397).
Report is 73 commits behind head on master.

Files Patch % Lines
src/subscriptions/service.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   54.05%   67.37%   +13.32%     
===========================================
  Files          15       31       +16     
  Lines         148      282      +134     
  Branches       25       64       +39     
===========================================
+ Hits           80      190      +110     
- Misses         65       87       +22     
- Partials        3        5        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julianajlk julianajlk merged commit 480cbbe into master Aug 9, 2024
5 checks passed
@julianajlk julianajlk deleted the julianajlk/REV-4003/remove-subs-stripe-portal-cta branch August 9, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants