-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: show subtitles for videos in full-screen mode #97
Conversation
@forgotvas It would be nice if you could also look as you did most of the work with videos. |
Hello @shafqat-muneer |
Hi @rnr, Once clarified, and if we decide to implement auto-scrolling to the highlighted content, I will handle it in a separate PR since it falls outside the scope of this one. |
@shafqat-muneer I'd like to point out that auto-scrolling now works in the 2U/develop branch (even after exiting fullscreen mode). Why did we decide to disable it? So other words it was working before this PR. |
@rnr It seems that the functionality may occasionally work, but not consistently. On the
|
I see what you mean - yes, it is broken when the user rewinds in fullscreen mode even in 2U/develop - I think we need to create a separate issue for this. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
LEARNER-10236: iOS - videos do not show captions when viewed full-screen
In the current implementation, subtitles are displayed only in full-screen mode, whether in landscape or portrait orientation. Subtitles are not shown in non-full-screen mode for two reasons. First, we cannot control the default caption on/off option provided by AVPlayer. Second, in normal mode, users can already view captions in any language, making it unnecessary to display additional subtitles. However, in full-screen mode, the option to view captions is unavailable, which is why we ensure subtitles are shown in that mode.
Note: Currently, there is no option to hide subtitles in full-screen mode. To enable this functionality, we would need to design a solution for it or opt for a fully custom implementation by hiding the default AVPlayer control bar.
Demo.Downloaded.Video.mov
Demo.Streaming.Video.mov