feat: Course Level Error Handling for Empty States #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Empty state for Home, Videos, Dates, and Discussion tabs. - Empty state for handouts, and Announcements screen. fixes: LEARNER-10039
farhan-arshad-dev
force-pushed
the
farhan_ar/LEARNER-10039
branch
from
d8566c3
to
766abbd
Compare
omerhabib26
approved these changes
Jul 18, 2024
k1rill
reviewed
Jul 18, 2024
| @@ -224,6 +227,10 @@ private fun CourseOutlineUI( | |||
| Box { | |||
| when (uiState) { | |||
| is CourseOutlineUIState.CourseData -> { | |||
| if (uiState.courseStructure.blockData.isEmpty()) { | |||
| NoContentScreen(noContentScreenType = NoContentScreenType.COURSE_OUTLINE) | |||
| return@Surface | |||
There was a problem hiding this comment.
Strange to se return inside compose
There was a problem hiding this comment.
NoContentScreen is a fullscreen error, so we don't want to show other content, so if the dates are empty return the flow, after showing the No content screen.
There was a problem hiding this comment.
I'm afraid that return will broke a compose tree, can you please use else in the CourseOutlineUIState.CourseData
dixidroid
approved these changes
Jul 18, 2024
k1rill
requested changes
Jul 22, 2024
k1rill
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Course Level Error Handling for Empty States
Tickets