Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Python 3.12 Upgrade #320

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat!: Python 3.12 Upgrade #320

merged 1 commit into from
Sep 19, 2024

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Sep 19, 2024 •
edited by varshamenon4
Loading

Description

  • Updated GitHub CI and tox to run checks with Python 3.12 env only
  • Updated requirements with Python 3.12 env
  • Updated Dockerfile to build with Python 3.12.
  • Dropped support for Python<3.12

Testing

  • Tested the docker build locally using make docker_build with updated Dockerfile to be successful.
  • CI checks with Python 3.12 are green.

@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

varshamenon4
varshamenon4 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@varshamenon4 varshamenon4 merged commit 87aa3f5 into main Sep 19, 2024
5 checks passed
@varshamenon4 varshamenon4 deleted the python312-upgrade branch September 19, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshamenon4 varshamenon4 varshamenon4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UsamaSadiq @varshamenon4