Skip to content

Commit

Permalink
Merge pull request #72 from edx/hamza442/DENG-1297
Browse files Browse the repository at this point in the history
fix: Updated dbt-core and dbt-snowflake version to resolve dependenci…
  • Loading branch information
Hamza442 authored Aug 18, 2022
2 parents a3c67ec + 70c0df6 commit 401ebac
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 4 deletions.
2 changes: 1 addition & 1 deletion dbt_schema_builder/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Automate management of PII redacted schemas for dbt projects.
"""

__version__ = '0.4.4'
__version__ = '0.4.5'
4 changes: 2 additions & 2 deletions requirements/base.in
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Core requirements for using this application
-c constraints.txt

dbt-core==1.0.3
dbt-snowflake==1.0.0
dbt-core==1.2.0
dbt-snowflake==1.2.0
17 changes: 16 additions & 1 deletion requirements/constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,19 @@
packaging==20.9
# Pinning snowflake-connector-python due to following issue
# https://github.com/snowflakedb/snowflake-connector-python/issues/1206
snowflake-connector-python==2.7.9
snowflake-connector-python==2.7.9

# Pinning below mentioned dependencies because when we do make upgrade there is conflict between dependencies
# snowflake-connector-python 2.7.9 install werkzeug 2.2.2 in which MarkupSafe is pinned to MarkupSafe>=2.1.1
# https://github.com/pallets/werkzeug/blob/2.2.2/setup.py
# This cause error: Could not find a version that matches MarkupSafe==2.0.1,==2.1.1 (from -c requirements/constraints.txt (line 17))
# Because in dbt-score 1.0.3 MarkupSafe is pinned to 2.0.1 and in dbt-score 1.2.0 MarkupSafe is pinned to MarkupSafe>=0.23,<2.1
# https://github.com/dbt-labs/dbt-core/blob/v1.2.0/core/setup.py#L52
# https://github.com/dbt-labs/dbt-core/blob/v1.0.3/core/setup.py#L55
# Due to this reason we are pinnig to werkzeug==2.1.2, becuase in this version MarkupSafe is not pinned
# https://github.com/pallets/werkzeug/blob/2.1.2/setup.py
# Also with this change dbt-core and dbt-snowflake version was dumped to 1.2.0 in base.in file
# becuase dbt-snowflake==1.0.0 has hard limit cryptography<4,>=3.2 and snowflake-connector-python==2.7.9 has hard limit cryptography<37.0.0,>=3.1.0.
# This was causing conflict so needed to upgrade dbt-snowflake and dbt-core to 1.2.0
werkzeug==2.1.2
charset-normalizer==2.0.12

0 comments on commit 401ebac

Please sign in to comment.