Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add EDXAPP_DDTRACE_PIP_SPEC to specify ddtrace version for edxapp #70

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

timmc-edx
Copy link
Member

This allows specifying the entire requirement spec, not just the version, because we want to be able install from HTTPS URLs or other sources, not just PyPI. (This will allow us to install a release candidate.)


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

…xapp

This allows specifying the entire requirement spec, not just the version,
because we want to be able install from HTTPS URLs or other sources, not
just PyPI. (This will allow us to install a release candidate.)
@timmc-edx timmc-edx merged commit a215923 into master Sep 24, 2024
4 checks passed
@timmc-edx timmc-edx deleted the timmc/ddtrace-version branch September 24, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants