Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added setting to set the default enabled state for course summaries #143

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Mar 14, 2025

Currently, the course summary is disabled by default. It needs to explicitly be enabled on the course configuration.

These changes allow to set the default enabled state by a setting. This does not overrides the waffle flag, meaning that even if the setting is set to be enabled by default, it can still be disabled by the course waffle flag, which takes priority.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Sorry, something went wrong.

@rijuma rijuma marked this pull request as draft March 14, 2025 15:00
@rijuma rijuma force-pushed the rijuma/use-config-for-summary-setting-enabled branch 2 times, most recently from fb1623a to e60cab8 Compare March 14, 2025 15:26
@rijuma rijuma force-pushed the rijuma/use-config-for-summary-setting-enabled branch from e60cab8 to 043a176 Compare March 14, 2025 15:33
@rijuma rijuma marked this pull request as ready for review March 14, 2025 15:34
Copy link

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rijuma rijuma merged commit f215362 into main Mar 17, 2025
4 checks passed
@rijuma rijuma deleted the rijuma/use-config-for-summary-setting-enabled branch March 17, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants