Test PE Feat/styling spec

.rubocop.yml

@@ -6,6 +6,7 @@ inherit_from:
 AllCops:
   TargetRubyVersion: 2.2
   Exclude:
+    - vendor/**/*
     - db/schema.rb
     - tmp/aruba/Guardfile
     - tmp/aruba/Gemfile

.rubocop_todo.yml

@@ -59,15 +59,15 @@ Style/NumericPredicate:
 
 # Offense count: 1
 # Cop supports --auto-correct.
-Style/SpaceInsideArrayPercentLiteral:
+Layout/SpaceInsideArrayPercentLiteral:
   Exclude:
     - 'guard.gemspec'
 
 # Offense count: 41
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: space, no_space
-Style/SpaceInsideStringInterpolation:
+Layout/SpaceInsideStringInterpolation:
   Exclude:
     - 'lib/guard.rb'
     - 'lib/guard/cli.rb'

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 gemspec unless ENV["USE_INSTALLED_GUARD"] == "1"
@@ -15,13 +17,13 @@ group :development do
   # on HoundCI's side.
   #
   # See https://github.com/houndci/hound/issues/1250
-  gem "rubocop", "0.51.0", require: false
+  gem "rubocop", "0.54.0", require: false
 
   gem "guard-rubocop", require: false
 
-  gem "yard", require: false, platform: :mri
-  gem "redcarpet", require: false, platform: :mri
   gem "guard-ronn", require: false, platform: :mri
+  gem "redcarpet", require: false, platform: :mri
+  gem "yard", require: false, platform: :mri
 
   # Used for release
   gem "gems", require: false, platform: :mri
@@ -37,19 +39,19 @@ group :test do
   gem "guard-cucumber", "~> 2.1", require: false
   gem "guard-rspec", require: false
 
-  gem "codeclimate-test-reporter", require: nil
-  gem "rspec", ">= 3.0.0", require: false
   gem "aruba", "~> 0.9", require: false
+  gem "codeclimate-test-reporter", require: nil
   gem "notiffany", ">= 0.0.6", require: false
+  gem "rspec", ">= 3.0.0", require: false
 end
 
 # Needed for Travis
 # See http://docs.travis-ci.com/user/languages/ruby/#Rubinius
 #
 platforms :rbx do
-  gem "racc"
-  gem "rubysl", "~> 2.0"
-  gem "psych"
   gem "json"
+  gem "psych"
+  gem "racc"
   gem "rubinius-coverage"
+  gem "rubysl", "~> 2.0"
 end

config/Guardfile

@@ -26,7 +26,7 @@ group :specs, halt_on_fail: true do
     #  watch(%r{^lib/guard/(guard|plugin).rb$}) { "spec/guard/plugin" }
   end
 
-  guard :rubocop, all_on_start: false, cli: "--rails" do
+  guard :rubocop, all_on_start: false, cli: "--rails -c .rubocop.yml" do
     watch(%r{.+\.rb$}) { |m| m[0] }
     watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
   end

features/support/env.rb

@@ -33,5 +33,5 @@
   set_environment_variable "HOME", home
   FileUtils.mkdir(home)
 
-  @aruba_timeout_seconds = Cucumber::JRUBY ? 35 : 15
+  @aruba_timeout_seconds = Cucumber::JRUBY ? 45 : 15
 end

spec/lib/guard/bin_spec.rb

@@ -1,4 +1,6 @@
-path = File.expand_path("../../../../bin/guard", __FILE__)
+# frozen_string_literal: true
+
+path = File.expand_path("../../../bin/guard", __dir__)
 load path
 
 RSpec.describe GuardReloader do
@@ -11,13 +13,13 @@
   before do
     allow(described_class::Config).to receive(:new).and_return(config)
 
-    allow(config).to receive(:current_bundler_gemfile).
-      and_return(bundle_gemfile_env)
+    allow(config).to receive(:current_bundler_gemfile)
+      .and_return(bundle_gemfile_env)
 
     allow(config).to receive(:using_bundler?).and_return(bundle_gemfile_env)
     allow(config).to receive(:guard_core_path).and_return(guard_core_path)
 
-    allow(config).to receive(:program_arguments).and_return(%w(foo bar baz))
+    allow(config).to receive(:program_arguments).and_return(%w[foo bar baz])
     allow(config).to receive(:using_rubygems?).and_return(rubygems_deps_env)
     allow(config).to receive(:program_path).and_return(program_path)
   end
@@ -54,8 +56,8 @@
 
         context "when the relative Gemfile exists" do
           before do
-            allow(config).to receive(:exist?).
-              with(Pathname("/my/project/Gemfile")).and_return(true)
+            allow(config).to receive(:exist?)
+              .with(Pathname("/my/project/Gemfile")).and_return(true)
 
             allow(config).to receive(:setup_bundler)
             allow(config).to receive(:setup_bundler_env)
@@ -67,19 +69,19 @@
           end
 
           it "sets the Gemfile" do
-            expect(config).to receive(:setup_bundler_env).
-              with("/my/project/Gemfile")
+            expect(config).to receive(:setup_bundler_env)
+              .with("/my/project/Gemfile")
             subject.setup
           end
         end
 
         context "when the relative Gemfile does not exist" do
           before do
-            allow(config).to receive(:exist?).
-              with(Pathname("/my/project/Gemfile")).and_return(false)
+            allow(config).to receive(:exist?)
+              .with(Pathname("/my/project/Gemfile")).and_return(false)
 
-            allow(config).to receive(:exist?).with(Pathname("Gemfile")).
-              and_return(false)
+            allow(config).to receive(:exist?).with(Pathname("Gemfile"))
+                                             .and_return(false)
           end
 
           it "does not setup bundler" do
@@ -110,8 +112,8 @@
 
         context "when Gemfile exists" do
           before do
-            allow(config).to receive(:exist?).with(Pathname("Gemfile")).
-              and_return(true)
+            allow(config).to receive(:exist?).with(Pathname("Gemfile"))
+                                             .and_return(true)
           end
 
           it "shows a warning" do
@@ -122,8 +124,8 @@
 
         context "when no Gemfile exists" do
           before do
-            allow(config).to receive(:exist?).with(Pathname("Gemfile")).
-              and_return(false)
+            allow(config).to receive(:exist?).with(Pathname("Gemfile"))
+                                             .and_return(false)
           end
 
           it "shows no warning" do

spec/lib/guard/cli/environments/bundler_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "guard/cli/environments/bundler"
 
 # TODO: instead of shared examples, use have_received if possible
@@ -22,8 +24,8 @@
       allow(ENV).to receive(:[]).with("BUNDLE_GEMFILE").and_return(gemfile)
       allow(ENV).to receive(:[]).with("RUBYGEMS_GEMDEPS").and_return(gemdeps)
 
-      allow(File).to receive(:exist?).with("Gemfile").
-        and_return(gemfile_present)
+      allow(File).to receive(:exist?).with("Gemfile")
+                                     .and_return(gemfile_present)
 
       subject.verify
     end

spec/lib/guard/cli/environments/evaluate_only_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "guard/cli/environments/evaluate_only"
 
 RSpec.describe Guard::Cli::Environments::EvaluateOnly do
@@ -35,11 +37,11 @@
 
     it "passes options to evaluator" do
       evaluator_options = double("evaluator_options")
-      allow(session).to receive(:evaluator_options).
-        and_return(evaluator_options)
+      allow(session).to receive(:evaluator_options)
+        .and_return(evaluator_options)
 
-      expect(Guard::Guardfile::Evaluator).to receive(:new).
-        with(evaluator_options).and_return(evaluator)
+      expect(Guard::Guardfile::Evaluator).to receive(:new)
+        .with(evaluator_options).and_return(evaluator)
 
       subject.evaluate
     end
@@ -52,8 +54,8 @@
     ].each do |error_class|
       context "when a #{error_class} error occurs" do
         before do
-          allow(Guard).to receive(:init).
-            and_raise(error_class, "#{error_class} error!")
+          allow(Guard).to receive(:init)
+            .and_raise(error_class, "#{error_class} error!")
         end
 
         it "aborts" do

spec/lib/guard/cli/environments/valid_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "guard/cli/environments/valid"
 require "guard/cli/environments/bundler"
 
@@ -14,8 +16,8 @@
     let(:bundler) { instance_double("Guard::Cli::Environments::Bundler") }
 
     before do
-      allow(Guard::Cli::Environments::Bundler).to receive(:new).
-        and_return(bundler)
+      allow(Guard::Cli::Environments::Bundler).to receive(:new)
+        .and_return(bundler)
 
       allow(bundler).to receive(:verify)
     end
@@ -24,8 +26,8 @@
       before do
         allow(bundler).to receive(:verify)
 
-        allow(options).to receive(:[]).with(:no_bundler_warning).
-          and_return(false)
+        allow(options).to receive(:[]).with(:no_bundler_warning)
+                                      .and_return(false)
       end
 
       it "starts guard" do
@@ -52,8 +54,8 @@
       ].each do |error_class|
         context "when a #{error_class} error occurs" do
           before do
-            allow(Guard).to receive(:start).
-              and_raise(error_class, "#{error_class} error!")
+            allow(Guard).to receive(:start)
+              .and_raise(error_class, "#{error_class} error!")
           end
 
           it "aborts" do
@@ -150,8 +152,8 @@
       end
 
       it "Only creates the Guardfile without initializing any Guard template" do
-        allow(evaluator).to receive(:evaluate).
-          and_raise(Guard::Guardfile::Evaluator::NoGuardfileError)
+        allow(evaluator).to receive(:evaluate)
+          .and_raise(Guard::Guardfile::Evaluator::NoGuardfileError)
 
         allow(File).to receive(:exist?).with("Gemfile").and_return(false)
         expect(generator).to receive(:create_guardfile)
@@ -178,12 +180,12 @@
       end
 
       it "creates a Guardfile" do
-        expect(evaluator).to receive(:evaluate).
-          and_raise(Guard::Guardfile::Evaluator::NoGuardfileError).once
+        expect(evaluator).to receive(:evaluate)
+          .and_raise(Guard::Guardfile::Evaluator::NoGuardfileError).once
         expect(evaluator).to receive(:evaluate)
 
-        expect(Guard::Guardfile::Generator).to receive(:new).
-          and_return(generator)
+        expect(Guard::Guardfile::Generator).to receive(:new)
+          .and_return(generator)
         expect(generator).to receive(:create_guardfile)
 
         subject.initialize_guardfile
@@ -203,30 +205,30 @@
         expect(generator).to receive(:initialize_template).with("rspec")
         expect(generator).to receive(:initialize_template).with("pow")
 
-        subject.initialize_guardfile(%w(rspec pow))
+        subject.initialize_guardfile(%w[rspec pow])
       end
 
       context "when passed a guard name" do
         context "when the Guardfile is empty" do
           before do
-            allow(evaluator).to receive(:evaluate).
-              and_raise Guard::Guardfile::Evaluator::NoPluginsError
+            allow(evaluator).to receive(:evaluate)
+              .and_raise Guard::Guardfile::Evaluator::NoPluginsError
             allow(generator).to receive(:initialize_template)
           end
 
           it "works without without errors" do
-            expect(subject.initialize_guardfile(%w(rspec))).to be_zero
+            expect(subject.initialize_guardfile(%w[rspec])).to be_zero
           end
 
           it "adds the template" do
             expect(generator).to receive(:initialize_template).with("rspec")
-            subject.initialize_guardfile(%w(rspec))
+            subject.initialize_guardfile(%w[rspec])
           end
         end
 
         it "initializes the template of the passed Guard" do
           expect(generator).to receive(:initialize_template).with("rspec")
-          subject.initialize_guardfile(%w(rspec))
+          subject.initialize_guardfile(%w[rspec])
         end
       end
 
@@ -236,16 +238,16 @@
 
       context "when passed an unknown guard name" do
         before do
-          expect(generator).to receive(:initialize_template).with("foo").
-            and_raise(Guard::Guardfile::Generator::NoSuchPlugin, "foo")
+          expect(generator).to receive(:initialize_template).with("foo")
+                                                            .and_raise(Guard::Guardfile::Generator::NoSuchPlugin, "foo")
         end
 
         it "returns an exit code" do
           expect(::Guard::UI).to receive(:error).with(
             "Could not load 'guard/foo' or '~/.guard/templates/foo'"\
             " or find class Guard::Foo\n"
           )
-          expect(subject.initialize_guardfile(%w(foo))).to be(1)
+          expect(subject.initialize_guardfile(%w[foo])).to be(1)
         end
       end
     end