Platform/RK3588: add files for using Firefly ITX-3588J board #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, just a few notes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is aimed at adding support for the Firefly ITX-3588J board. It contains both the board support files and one new (but perhaps a bit rough) driver for the PCA9555 GPIO extension chipset on the board which is needed to control many peripheral devices to the Rockchip SoC there. Last time I tested it - and if I copied it from my original development source copy right to post here! - everything seemed to work well for the most part. One problem is that it seems that for some reason at least the BSP-provided Linux kernels don't get GMAC information in ACPI configuration mode, but I'm also not sure that's a problem solely related to this board, or the EDK2, or is instead the fault of those weird kernels. There is also a Device Tree Blob (DTB) included here as well based on that from "firefly-linux" for BSP kernel 5.10.160 (if I remember right) provided here.