-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support spelling_language property #210
base: master
Are you sure you want to change the base?
Conversation
You are right, it need to be added to the spec first: spec.editorconfig.org. The plugin is a implementation of the spec for Vim. |
Draft specification change using |
I don't know how the tests work, but there's a spelling_language in the specification now so here's the implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I am just requesting one change. Thanks for this PR!
Sure, fixed this. Just to mention, the specification is a bit vague on which territory codes are actually included, the ISO lists all of |
Thanks! As for two- vs. three-letter codes, I intended
to be exactly two characters, but your point is well made --- |
@gustaphe Spec fix open at editorconfig/specification#54 |
Just checking, is there anything blocking this merge? |
I implemented the discussion in editorconfig/editorconfig#315 . Perhaps this is the wrong way around - it should be put in the standard first. But I don't know how to edit the standard, I know how to edit the implementation.
I'm currently running off my own fork, but in case the standard is updated at least this practical implementation is ready.