Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test keys set to empty strings #52

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Test keys set to empty strings #52

merged 2 commits into from
Sep 22, 2024

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Jan 28, 2024

parser/CMakeLists.txt Outdated Show resolved Hide resolved
@cxw42
Copy link
Member

cxw42 commented Feb 11, 2024

Would it also be worth adding a testcase to parser/whitespace.in like

key= value with whitespace inside  $

($ = end of line)? That way we would expressly show the behaviour of preserving whitespace inside values. Currently we test that implicitly in comments.in, test semicolon_or_hash_in_property, but we don't have a test in the whitespace group for it.

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 12, 2024

Would it also be worth adding a testcase to parser/whitespace.in like

key= value with whitespace inside  $

($ = end of line)? That way we would expressly show the behaviour of preserving whitespace inside values. Currently we test that implicitly in comments.in, test semicolon_or_hash_in_property, but we don't have a test in the whitespace group for it.

Done in 9877f04

Could you please review again?

@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 20, 2024

Any chance to re-review @cxw42 or anybody else?

@xuhdev xuhdev requested a review from cxw42 September 20, 2024 22:31
parser/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@cxw42 cxw42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once that comment is fixed!

@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 22, 2024

a665d19: s/key/value/ in the comment as requested by reviewers

parser/empty_values.in Outdated Show resolved Hide resolved
@xuhdev xuhdev merged commit e196495 into editorconfig:master Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants