Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation, fix reinstall table already exists, fix deprecated datetime, Add german translation #86

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

invisiblemarcel
Copy link
Contributor

These changes are pulled separately because of the major changes.

  • I always needed to drop the tables manually when I uninstalled the plugin, so I added 2 checks to avoid that.
  • It was not enough to copy a .po File for translation, I needed to compile them so I add a note in the Readme and compiled all lang files and added them to the repo (I know binary files in git are crap but it's much easier for the users)
  • German translation added
  • The table column type datetime is deprecated so I changed it to timestamp, before you always needed to run a command displayed in the UI to migrate it

Copy link
Owner

@edgardmessias edgardmessias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, could you rebase your PR?
My suggestion: split the PR for each type of change

.gitignore Outdated Show resolved Hide resolved
generic_examples/zitadel.md Outdated Show resolved Hide resolved
hook.php Show resolved Hide resolved
@edgardmessias edgardmessias merged commit 17afcc9 into edgardmessias:master Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants