Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a graphql svg icon which is around of 658 bytes . #866

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Akrati00
Copy link

@Akrati00 Akrati00 commented Oct 23, 2024

Thank you for your contribution! Before sending this Pull Request, please confirm the following:

  • You have read the contributing guidelines
  • The icon's size is under 1,024 Bytes
  • The layout of the SVG looks like this including newlines
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

If you have done the above, please send the Pull Request.

@edent
Copy link
Owner

edent commented Oct 23, 2024

@Akrati00 did you read the Contributing guidelines?

@Akrati00
Copy link
Author

@Akrati00 did you read the Contributing guidelines?

yes

@edent
Copy link
Owner

edent commented Oct 23, 2024

You ticked a Box saying it had this layout

<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

Does it have that layout? Can you see how your submission differs from the guidelines?

@Akrati00
Copy link
Author

You ticked a Box saying it had this layout

<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

Does it have that layout? Can you see how your submission differs from the guidelines?

yes I saw now .. dimensions are different?Will you check now is it okay?

@edent
Copy link
Owner

edent commented Oct 24, 2024

@Akrati00 I need you to actually read all of https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md

It has all the information you need.

@Akrati00
Copy link
Author

@Akrati00 I need you to actually read all of https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md

It has all the information you need.

okay sure

@edent
Copy link
Owner

edent commented Oct 24, 2024

You need to read https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md#guidelines

Your icon must fit in the green circle.

@edent
Copy link
Owner

edent commented Oct 26, 2024

@Akrati00 Please do not push commits until you are ready. Additionally, I recommend not using AI to try and generate this. You can ask questions if you're having trouble.

@Akrati00
Copy link
Author

Akrati00 commented Oct 26, 2024

@Akrati00 Please do not push commits until you are ready. Additionally, I recommend not using AI to try and generate this. You can ask questions if you're having trouble.

okay thanks... I will try changes first in another branch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants