Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xlink (duplicates #543) #804

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

romain-dartigues
Copy link
Collaborator

Got to much time on my hands and I noticed that xlink has been deprecated, saving a few bytes here and there.

(Thanks to that, Glitch and Minecrat can go under 1kB!)

SVG 2 removed the need for the xlink namespace, so instead of xlink:href you should use href.
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href

This is a duplicate of #543; since then it seems it's support is more widely available.

Thoughs?

@edent
Copy link
Owner

edent commented Sep 20, 2024

These all work in Firefox, Chrome, and Webkit. Also work in Gnome Image Viewer, GIMP, and InkScape.

Please can you run update_readme.py and then I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants