Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BoundingRect intersection check #1081

Closed
wants to merge 1 commit into from

Conversation

JesseSDevaney
Copy link

@JesseSDevaney JesseSDevaney commented Jun 25, 2024


Bug Fix: This PR is intended to fix the hideOverlap functionality in ECharts by preventing empty labels ("") from being considered as candidates for the overlap checking.

  • An empty label is also a bounding rect with width and height <= 0

If either of the bounding rects being compared has a width and height that are less than or equal to zero, short-circuit the function and return false for the intersection check.
@Ovilia
Copy link
Member

Ovilia commented Jun 28, 2024

Closed due to apache/echarts#19982 (review)

@Ovilia Ovilia closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants