Made the wrapping algorithm more closely align with Unicode Standard #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wetterquarz
changed the title
Wrapping now happens after spaces instead of before and only after the last space in a sequence of spaces. Characters which should not have a line break in front of them have been removed form the list, which become redundant as a consequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Spaces are now treated according to Unicode Standard (https://www.unicode.org/reports/tr14/#SP).
It now correctly reads in all characters as a single character.
Fixed issues
Fixes apache/echarts#18583
Details
Before: What was the problem?
It is possible for a wrapped line to start with a space, which may not happen if the line break was not intentional. And breaks to happen within characters.
After: How does it behave after the fixing?
Line breaks are now only inserted after the last space and trailing spaces are ignored for line breaking, as required by the Unicode standard. Characters which consist of two chars in JavaScript are now treated as one.
Documentation Info
One of the following should be checked.
Misc
Related test cases or examples to use the new APIs
/test/text-overflow.html
Others
Merging options