Cleanup comments and update dependencies

- Cleanup comments
- Cleanup and update dependencies
- Fix undefined args issue
- Fix typo and skip console output on skipPrompting
- Add missing react-redux dependency

generator-jsonforms/package.json

@@ -28,6 +28,7 @@
     "yeoman-generator": "^3.2.0"
   },
   "devDependencies": {
-    "typescript": "^3.2.2"
+    "@types/figlet": "^1.2.0",
+    "typescript": "^3.3.3333"
   }
 }

generator-jsonforms/src/generators/app/index.ts

@@ -1,15 +1,14 @@
 // tslint:disable:no-var-requires
 // tslint:disable:no-require-imports
-'use strict';
 
 import Generator from 'yeoman-generator';
 import chalk from 'chalk';
-const clear = require('clear');
-const figlet = require('figlet');
-const validate = require('validate-npm-package-name');
+import { textSync } from 'figlet';
 import { join, sep } from 'path';
 import { readFile, writeFile } from 'fs';
 import { promisify } from 'util';
+const clear = require('clear');
+const validate = require('validate-npm-package-name');
 
 enum ProjectRepo {
   Example = 'make-it-happen-react',
@@ -45,7 +44,7 @@ export class JsonformsGenerator extends Generator {
     this.repo = '';
     this.path = this.options.path;
     this.name = this.options.name;
-    this.skipPrompting = this.options.skipPromting;
+    this.skipPrompting = this.options.skipPrompting;
 
     if (this.project === Project.Example) {
       this.repo = ProjectRepo.Example;
@@ -56,13 +55,13 @@ export class JsonformsGenerator extends Generator {
   }
 
   async prompting() {
-    clear();
-    this.log(
-      chalk.blue(
-        figlet.textSync('JSONForms Tooling', { horizontalLayout: 'full' }),
-      ),
-    );
     if (!this.skipPrompting) {
+      clear();
+      this.log(
+        chalk.blue(
+          textSync('JSONForms Tooling', { horizontalLayout: 'full' }),
+        ),
+      );
       this.answers = await this.prompt([
         {
           name: 'project',

jsonforms-tooling-common/package.json

@@ -9,7 +9,7 @@
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
     "build": "npm run compile",
-    "compile": "rimraf out && tsc -p ./ --declaration",
+    "compile": "rimraf out && tsc -p ./ --declaration --skipLibCheck",
     "postinstall": " ",
     "custominstall": "npm run postinstall",
     "lint": "tslint --project tsconfig.json"
@@ -19,6 +19,7 @@
     "@jsonforms/react": "^2.2.0",
     "ajv": "^6.5.5",
     "react": "^16.8.3",
+    "react-redux": "^6.0.0",
     "redux": "^3.0.0",
     "util": "^0.11.1",
     "chokidar": "^2.1.2",

jsonforms-tooling-common/src/index.ts

@@ -20,7 +20,7 @@ const writeFileWithPromise = promisify(writeFile);
 
 /*
  * @param {any} editorInstance the instance of the editor
- * @param {string} path the arguments passed to the editor call
+ * @param {string} path the path for the project
  * @param {string} project the project, that should be installed
  */
 export const createProject = async (editorInstance: any, path: string, project: string) => {
@@ -49,7 +49,7 @@ export const createProject = async (editorInstance: any, path: string, project:
 /**
  * Generates the default UI Schema from a json schema
  * @param {any} editorInstance the instance of the editor
- * @param {string} path the arguments passed to the editor call
+ * @param {string} path the path to the schema file
  */
 export const generateUISchema = async (editorInstance: any, path: string) => {
   if (!path) {