Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in RTS signal for UART0 #955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Typo in RTS signal for UART0 #955

wants to merge 1 commit into from

Conversation

focalplane
Copy link

No description provided.

Copy link
Contributor

@Mani-Sadhasivam Mani-Sadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @focalplane,

Change looks good but as per MRAA contribution guidelines you need to rework this PR. https://github.com/intel-iot-devkit/mraa/blob/master/CONTRIBUTING.md#basic-rules

@alext-mkrs
Copy link
Contributor

@focalplane thanks for your correction, but yes, specifically, please add a sign-off line into your commit message and add an affected file/module name into the commit message summary. The link @Mani-Sadhasivam shared is the full information on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants