Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rockpi S #1110

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Rockpi S #1110

wants to merge 6 commits into from

Conversation

ChangPaul
Copy link

Added support for Rock Pi S platform.

api/mraa/types.h Outdated
Comment on lines 66 to 72
MRAA_ADLINK_IPI = 21, /**< Adlink Industrial PI */
MRAA_ADLINK_LEC_AL = 22, /**< Adlink LEC-AL*/
MRAA_ADLINK_LEC_AL_AI = 23, /**< Adlink LEC-AL*/
MRAA_UPXTREME = 24, /**< The UPXTREME Board */
MRAA_INTEL_ILK = 25, /**< Intel Learning Kit */
MRAA_SIEMENS_IOT2050 = 26, /**< Siemens IOT2050 board */
MRAA_ROCKPIS = 21, /**< Radxa ROCK PI S */
MRAA_ADLINK_IPI = 22, /**< Adlink Industrial PI */
MRAA_ADLINK_LEC_AL = 23, /**< Adlink LEC-AL*/
MRAA_ADLINK_LEC_AL_AI = 24, /**< Adlink LEC-AL*/
MRAA_UPXTREME = 25, /**< The UPXTREME Board */
MRAA_INTEL_ILK = 26, /**< Intel Learning Kit */
MRAA_SIEMENS_IOT2050 = 27, /**< Siemens IOT2050 board */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest AGAINST changing existing constant's value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, Please dont ever change these constants. There might be downstream code that depends on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants