-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROS 2 action CI for the bridge #370
Conversation
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
PR missing one of the required labels: {'documentation', 'enhancement', 'new feature', 'breaking-change', 'internal', 'dependencies', 'bug'} |
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For easier understanding of tests organisation, each filename should reflect the test it contains. e.g.: action_client.rs
=> test_ros_client_zenoh_action.rs
.
For topics.rs
that contain 2 tests, maybe test_pub_sub.rs
.
I think the _action/feedback
topic should also be tested. But that could come later in a separate PR.
Signed-off-by: ChenYing Kuo <[email protected]>
It makes sense to me. I've renamed the file.
I agree with you. I've added a TODO comment in the code for the future update. |
After supporting the topic and service, this is the last part to verify ROS 2 action communication with bridge.