Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS 2 action CI for the bridge #370

Merged
merged 9 commits into from
Dec 27, 2024

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Dec 27, 2024

After supporting the topic and service, this is the last part to verify ROS 2 action communication with bridge.

Copy link

PR missing one of the required labels: {'documentation', 'enhancement', 'new feature', 'breaking-change', 'internal', 'dependencies', 'bug'}

@evshary evshary added the internal Changes not included in the changelog label Dec 27, 2024
@evshary evshary requested a review from JEnoch December 27, 2024 06:40
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Copy link
Member

@JEnoch JEnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For easier understanding of tests organisation, each filename should reflect the test it contains. e.g.: action_client.rs => test_ros_client_zenoh_action.rs.
For topics.rs that contain 2 tests, maybe test_pub_sub.rs.

I think the _action/feedback topic should also be tested. But that could come later in a separate PR.

@evshary
Copy link
Contributor Author

evshary commented Dec 27, 2024

For easier understanding of tests organisation, each filename should reflect the test it contains. e.g.: action_client.rs => test_ros_client_zenoh_action.rs. For topics.rs that contain 2 tests, maybe test_pub_sub.rs.

It makes sense to me. I've renamed the file.

I think the _action/feedback topic should also be tested. But that could come later in a separate PR.

I agree with you. I've added a TODO comment in the code for the future update.

@evshary evshary requested a review from JEnoch December 27, 2024 12:47
@JEnoch JEnoch merged commit 300cc55 into eclipse-zenoh:main Dec 27, 2024
9 checks passed
@evshary evshary deleted the add_ros_action_ci branch December 30, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants