Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SSE data reporting #1298

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

danielpeintner
Copy link
Member

fixes #1294

@danielpeintner danielpeintner changed the title fix: SSE event data reporting fix: SSE data reporting Jul 2, 2024
@egekorkan
Copy link
Member

egekorkan commented Jul 4, 2024

Some comments:

Given that 1 is always the case for sse and we can understand that from subprotocol, it is fine to put json in the form content type.

@danielpeintner
Copy link
Member Author

Given that 1 is always the case for sse and we can understand that from subprotocol, it is fine to put json in the form content type.

This is something that (I think) goes beyond this PR. I suggest to open another issue/PR for that.

@egekorkan w.r.t. the other comments I am not sure whether they affect "this" PR. There is a test added that checks the consistency of the change. Do you want me to change the PR further?

@egekorkan
Copy link
Member

Given that 1 is always the case for sse and we can understand that from subprotocol, it is fine to put json in the form content type.

This is something that (I think) goes beyond this PR. I suggest to open another issue/PR for that.

@egekorkan w.r.t. the other comments I am not sure whether they affect "this" PR. There is a test added that checks the consistency of the change. Do you want me to change the PR further?

I think I got confused after some discussions with @relu91 and commented here. My comments do not affect this PR.

@danielpeintner danielpeintner merged commit 5e2b362 into eclipse-thingweb:master Jul 8, 2024
10 checks passed
@VigneshVSV
Copy link

works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

observe property deserialized value (may) not (be) completely consistent
4 participants