Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual AI code completion #14393

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JonasHelming
Copy link
Contributor

@JonasHelming JonasHelming commented Nov 3, 2024

What it does

fixed #14392

  • Remove enable setting for code completion
  • Add setting whether the code completion is triggered automatically

How to test

Go to settings => code completion and toggle "Automatic Code Completion"
If "Automatic" => code completion immediatly appears
If Not "automatic" => code completion only appears on SHIFT+SPACE

If AI is generally disabled or the code completion agent is disabled, none of the two options trigger

Follow-ups

It might be nice to show some sort of progress for the non-automatic option, especially for slower LLMS.

Review checklist

Reminder for reviewers

- Add preference to turn on/off automatic trigger while editing
- Add shortcut for explicit, manual trigger through command
Signed-off-by: Jonas Helming <[email protected]>
@JonasHelming JonasHelming changed the title Issues/ai manual completion Add manual AI code completion Nov 3, 2024
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs merge
Development

Successfully merging this pull request may close these issues.

[Theia AI] Inline code completion is a bit invasive (145)
3 participants