Support version for installExtension, support uninstall cmd #14298
Conversation
| @@ -81,4 +81,31 @@ export namespace PluginIdentifiers { | |||
| } | |||
| return { id: probablyId.slice(0, endOfName) as UnversionedId, version: probablyId.slice(endOfName + 1) }; | |||
| } | |||
|
|
|||
| const EXTENSION_IDENTIFIER_WITH_VERSION_REGEX = /^([^.]+\..+)@((prerelease)|(\d+\.\d+\.\d+(-.*)?))$/; | |||
There was a problem hiding this comment.
This is unnecessarily restrictve, IMO: all we need to know here is what is before the '@' and what is after the '@'. Why introduce the added complexity? Also, regexes should always have a comment that describes what they are supposed to detect, Because no-one understands Regexes at first sight. If the id does not match the expression, you end up with the exact same result as before.
| if (!id) { | ||
| throw new Error(nls.localizeByDefault('Extension id required.')); | ||
| } | ||
| if (!PluginIdentifiers.isVersionedId(id)) { |
There was a problem hiding this comment.
I don't think this makes sense from a user's perspective: while technically, we can have multiple versions of the same plugin installed, that's not how it's presented to the user: for them, you either have a plugin installed, or not, independent of the version, so we should probably pass a naked id here.
| @@ -324,8 +325,10 @@ export class VSXExtension implements VSXExtensionData, TreeElement { | |||
| if (plugin) { | |||
| await this.progressService.withProgress( | |||
| nls.localizeByDefault('Uninstalling {0}...', this.id), 'extensions', | |||
| () => this.pluginServer.uninstall(PluginIdentifiers.componentsToVersionedId(plugin.metadata.model)) | |||
| ); | |||
| async () => { | |||
There was a problem hiding this comment.
Why go through the command here? Why stringify/destringify the id?
| @@ -28,60 +30,59 @@ import { | |||
| } from '@theia/core/lib/browser'; | |||
| import { ContextKeyService } from '@theia/core/lib/browser/context-key-service'; | |||
| import { ApplicationShellMouseTracker } from '@theia/core/lib/browser/shell/application-shell-mouse-tracker'; | |||
| import { SelectableTreeNode } from '@theia/core/lib/browser/tree/tree-selection'; | |||
There was a problem hiding this comment.
It's unfortunate that all the imports in this file are rewriten. It just adds noise to the PR.
What it does
Allows to use version when executing
workbench.extensions.installExtensioncommand in format<extensionId>@<version>#13795Adds support for
workbench.extensions.uninstallExtensioncommand #13796How to test
Run uninstall on some installed extension.
extension.uninstallnow uses the newworkbench.extensions.uninstallExtensionunder the hood.Install command
workbench.extensions.installExtensionis currently not used in Theia with astringparameter, one need to create a separate command.Follow-ups
Review checklist
Reminder for reviewers