Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs-check-refactor #208

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexanderLanin
Copy link
Member

@AlexanderLanin AlexanderLanin commented Jan 22, 2025

Update

As we have merged #226 this PR is now a draft of how the rest could be adapted. Note that it is incomplete and not working. We'll keep this PR for a few days as reference for a proper fix.

@hoe-jo
Copy link
Contributor

hoe-jo commented Jan 23, 2025

Shall we place the metamodel in a separate directory where process group is codeowner?

@AlexanderLanin
Copy link
Member Author

Shall we place the metamodel in a separate directory where process group is codeowner?

I was even considering moving it completely to the process directory. We'll see.
Anyhow CODEOWNERS also works on individual files, not only directories.

@AlexanderLanin AlexanderLanin added the infrastructure General Score infrastructure topics label Jan 23, 2025
@AlexanderLanin AlexanderLanin self-assigned this Jan 24, 2025
@AlexanderLanin AlexanderLanin force-pushed the docs-check-refactor branch 2 times, most recently from 9c55e05 to 95fcefd Compare January 24, 2025 20:42

def setup(app: Sphinx):
app.config.needs_id_required = True
app.config.needs_id_regex = "^[A-Za-z0-9_-]{6,}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls adapt ID to defined format

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original goal was a no-change refactoring... but I failed horribly 😆

In order to make the tests pass, I had to adjust them a little... and a little more... and a little more... and then I thought, it would just be easier to take a different approach 🤣

I'll look into this setting as well. Potentially removing it completely, as ID format is better checked via the usual metamodel checks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-as-code infrastructure General Score infrastructure topics
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants