-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs-check-refactor #208
base: main
Are you sure you want to change the base?
Docs-check-refactor #208
Conversation
Shall we place the metamodel in a separate directory where process group is codeowner? |
I was even considering moving it completely to the process directory. We'll see. |
9c55e05
to
95fcefd
Compare
|
||
def setup(app: Sphinx): | ||
app.config.needs_id_required = True | ||
app.config.needs_id_regex = "^[A-Za-z0-9_-]{6,}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls adapt ID to defined format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original goal was a no-change refactoring... but I failed horribly 😆
In order to make the tests pass, I had to adjust them a little... and a little more... and a little more... and then I thought, it would just be easier to take a different approach 🤣
I'll look into this setting as well. Potentially removing it completely, as ID format is better checked via the usual metamodel checks anyway.
8a1430d
to
eddf944
Compare
Update
As we have merged #226 this PR is now a draft of how the rest could be adapted. Note that it is incomplete and not working. We'll keep this PR for a few days as reference for a proper fix.