Make PDFDocument extend Device instead of implementing Drawable #3063
+407
−357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
pdf_is_a_device
branch
from
c9a4e9e to
1d20801
Compare
Contributor
laeubi
force-pushed
the
pdf_is_a_device
branch
from
517a683 to
96f8a4e
Compare
Change PDFDocument to subclass Device rather than implement Drawable to centralize resource management, align with Device lifecycle, and simplify drawing logic. This also fixes some complication with the windows implementation that possibly chooses bad defaults and confuses screen DPI with PDF defaults (72 DPI). Further the classes are made final and marked as experimental.
laeubi
force-pushed
the
pdf_is_a_device
branch
from
7da3f60 to
b85d25e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
PDFDocumentto subclassDevicerather than implementDrawableto centralize resource management, align withDevicelifecycle, and simplify drawing logic.This also fixes some complication with the windows implementation that possibly chooses bad defaults and confuses screen DPI with PDF defaults (72 DPI).
Further the classes are now made
finalto prevent complications in future enhancements as sub-classes are not useful here.