Skip to content

Enable zooming on macOS WebKit control with Command +/- keys #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobiasmelcher wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −0
Open

Enable zooming on macOS WebKit control with Command +/- keys #3048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT PI/cocoa/org/eclipse/swt/internal/cocoa/OS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,6 +991,8 @@ public static Selector getSelector (long value) {
public static final long sel_canBecomeKeyWindow = Selector.sel_canBecomeKeyWindow.value;
public static final long sel_canDragRowsWithIndexes_atPoint_ = Selector.sel_canDragRowsWithIndexes_atPoint_.value;
public static final long sel_canGoBack = Selector.sel_canGoBack.value;
public static final long sel_makeTextLarger = Selector.sel_makeTextLarger.value;
public static final long sel_makeTextSmaller = Selector.sel_makeTextSmaller.value;
public static final long sel_canGoForward = Selector.sel_canGoForward.value;
public static final long sel_canRedo = Selector.sel_canRedo.value;
public static final long sel_canShowMIMEType_ = Selector.sel_canShowMIMEType_.value;
Expand Down
2 changes: 2 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT PI/cocoa/org/eclipse/swt/internal/cocoa/Selector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,8 @@ public enum Selector {
, sel_canBecomeKeyWindow("canBecomeKeyWindow")
, sel_canDragRowsWithIndexes_atPoint_("canDragRowsWithIndexes:atPoint:")
, sel_canGoBack("canGoBack")
, sel_makeTextLarger("makeTextLarger:")
, sel_makeTextSmaller("makeTextSmaller:")
, sel_canGoForward("canGoForward")
, sel_canRedo("canRedo")
, sel_canShowMIMEType_("canShowMIMEType:")
Expand Down
8 changes: 8 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT PI/cocoa/org/eclipse/swt/internal/cocoa/WebView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ public boolean canGoBack() {
return OS.objc_msgSend_bool(this.id, OS.sel_canGoBack);
}

public void makeTextLarger() {
OS.objc_msgSend(this.id, OS.sel_makeTextLarger);
}

public void makeTextSmaller() {
OS.objc_msgSend(this.id, OS.sel_makeTextSmaller);
}

public boolean canGoForward() {
return OS.objc_msgSend_bool(this.id, OS.sel_canGoForward);
}
Expand Down
4 changes: 4 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT WebKit/cocoa/org/eclipse/swt/browser/WebKit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1586,6 +1586,10 @@ void handleEvent(long evtId) {
} else if (translatedKey == 'x') {
webView.cut (webView);
event.preventDefault();
} else if (translatedKey == '=' || translatedKey == '+') {
webView.makeTextLarger();
} else if (translatedKey == '-') {
webView.makeTextSmaller();
}
}
}
Expand Down
Loading