Redraw Missing SVG for org.eclipse.ui.intro Bundle#146
Redraw Missing SVG for org.eclipse.ui.intro Bundle#146HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
Conversation
|
@Michael5601: Can you please review? |
The icon looks good to me, thanks for creating it. :) Only two remark (which both are not that important): And you could also make sure that the icon is centered correctly (X == 0). |
you are right. I will force push a new version. |
510d303 to
667ee7c
Compare
done as well |
HeikoKlare
left a comment
There was a problem hiding this comment.
Looks good, thank you! Should we merge and also integrate in eclipse.platform for the upcoming release?
From my side this would be ok. Especially because it's the last missing one in that bundle. But one should have a look at how it looks like inside the running IDE before merging. I made the experience that you cannot simply judge if it looks good simply have looking the SVG standalone. If it looks good in the running IDE then I think it's ok to add it. |
Done and posted results in: |

I have the feeling I have drawn this SVG already some years ago when I added the @2x.png file. But I couldn't find it.