Skip to content
This repository was archived by the owner on Aug 11, 2025. It is now read-only.

Redraw Missing SVG for org.eclipse.ui.intro Bundle#146

Merged
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
BeckerWdf:restore_welcome
May 19, 2025
Merged

Redraw Missing SVG for org.eclipse.ui.intro Bundle#146
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
BeckerWdf:restore_welcome

Conversation

@BeckerWdf
Copy link
Member

I have the feeling I have drawn this SVG already some years ago when I added the @2x.png file. But I couldn't find it.

@BeckerWdf
Copy link
Member Author

@Michael5601: Can you please review?

@BeckerWdf BeckerWdf self-assigned this May 15, 2025
@Michael5601
Copy link
Contributor

Michael5601 commented May 15, 2025

@Michael5601: Can you please review?

The icon looks good to me, thanks for creating it. :)

Only two remark (which both are not that important):
These bottom three paths seem to have no effect and can thus be deleted reducing the file size and rasterization time.
image

And you could also make sure that the icon is centered correctly (X == 0).

@BeckerWdf
Copy link
Member Author

BeckerWdf commented May 15, 2025

These bottom three paths seem to have no effect and can thus be deleted reducing the file size and rasterization time

you are right. I will force push a new version.

@BeckerWdf
Copy link
Member Author

And you could also make sure that the icon is centered correctly (X == 0).

done as well

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Should we merge and also integrate in eclipse.platform for the upcoming release?

@BeckerWdf
Copy link
Member Author

Looks good, thank you! Should we merge and also integrate in eclipse.platform for the upcoming release?

From my side this would be ok. Especially because it's the last missing one in that bundle.

But one should have a look at how it looks like inside the running IDE before merging. I made the experience that you cannot simply judge if it looks good simply have looking the SVG standalone. If it looks good in the running IDE then I think it's ok to add it.

@HeikoKlare
Copy link
Contributor

But one should have a look at how it looks like inside the running IDE before merging. I made the experience that you cannot simply judge if it looks good simply have looking the SVG standalone. If it looks good in the running IDE then I think it's ok to add it.

Done and posted results in:

@HeikoKlare HeikoKlare merged commit 8df8427 into eclipse-platform:master May 19, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants