Improve VectorAPI Expansion IL transformation phase #21013
Merged
+191
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gita-omr
commented
Jan 24, 2025
gita-omr
commented
- only use elementType, vectorBitLength, and objectType info calculated during analysis phase (e.g. don't analyze nodes again)
- use objectType info when selecting opcode to distinguish between Vector and Mask operations. For example, some binary operations can be for vectors and for masks and require different opcodes
- since we don't determine object type during the transformation phase, do it during the analysis phase for load and store intrinsics
- only use elementType, vectorBitLength, and objectType info calculated during analysis phase (e.g. don't analyze nodes again) - use objectType info when selecting opcode to distinguish between Vector and Mask operations. For example, some binary operations can be for vectors and for masks and require different opcodes - since we don't determine object type during the transformation phase, do it during the analysis phase for load and store intrinsics
knn-k
reviewed
Jan 27, 2025
| if (_aliasTable[methodRefNum]._objectType == Unknown && | ||
| isVectorAPICall) | ||
| { | ||
| if (methodSymbol->getRecognizedMethod() == TR::jdk_internal_vm_vector_VectorSupport_load || | ||
| methodSymbol->getRecognizedMethod() == TR::jdk_internal_vm_vector_VectorSupport_store || |
There was a problem hiding this comment.
This line seems to be the only difference from PR #20972.
|
Jenkins test sanity xlinux jdk21 |
knn-k
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.