Stop setting known object index in findOrCreateStaticSymbol() #21009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SymbolReferenceTable::findOrCreateStaticSymbol() is used only when generating IL for putstatic and getstatic. For putstatic, if it attempts to store to a static final field, it's very likely that the store is illegal, in which case it will be treated as unresolved. But even if the store is legal, the known object index is useless. For getstatic, the IL generator will use foldReliableStaticFinalField() from TransformUtil to get the same effect anyway, so setting the known object index here is redundant.
|
@0xdaryl, could you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SymbolReferenceTable::findOrCreateStaticSymbol()is used only when generating IL forputstaticandgetstatic.For
putstatic, if it attempts to store to a static final field, it's very likely that the store is illegal, in which case it will be treated as unresolved. But even if the store is legal, the known object index is useless.For
getstatic, the IL generator will usefoldReliableStaticFinalField()fromTransformUtilto get the same effect anyway, so setting the known object index here is redundant.