Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing JFR to get J9Class of hidden and anonymous classes #20979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allowing JFR to get J9Class of hidden and anonymous classes #20979

wants to merge 1 commit into from

Conversation

thallium
Copy link
Contributor

No description provided.

@thallium
Copy link
Contributor Author

@tajila can you please review?

@tajila tajila requested a review from theresa-m January 20, 2025 21:00
tajila
tajila reviewed Jan 21, 2025
View reviewed changes
runtime/vm/KeyHashTable.c Outdated
@@ -333,7 +342,7 @@ hashClassTableNew(J9JavaVM *javaVM, U_32 initialSize)
}

J9Class *
hashClassTableAt(J9ClassLoader *classLoader, U_8 *className, UDATA classNameLength)
hashClassTableAt(J9ClassLoader *classLoader, U_8 *className, UDATA classNameLength, BOOLEAN ignoreHiddenClass)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have mentioned this earlier, but you can make:

hashClassTableAtImpl(J9ClassLoader *classLoader, U_8 *className, UDATA classNameLength, BOOLEAN ignoreHiddenClass) { }

and then

hashClassTableAt(J9ClassLoader *classLoader, U_8 *className, UDATA classNameLength) 
{
    return hashClassTableAtImpl(classLoader, className, classNameLength, TRUE); 
}

So you dont need to update all the places its used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated my PR. I added hashClassTableAtImpl to vm_api.h, is that what I'm supposed to do?

@tajila
Copy link
Contributor

tajila commented Jan 22, 2025

jenkins test sanity,extended.functional,extended.opendk,sanity.special alinux64 jdk17

@tajila
Copy link
Contributor

tajila commented Jan 24, 2025

@thallium There are crashes in the tests:

11:23:24  Attempting to destroy all caches in cacheDir /home/jenkins/.cache/javasharedresources/
11:23:24  
11:23:24  JVMSHRC806I Compressed references persistent shared cache "sharedcc_jenkins" has been destroyed. Use option -Xnocompressedrefs if you want to destroy a non-compressed references cache.
11:23:24  JVMSHRC807I Non-compressed references persistent shared cache "sharedcc_jenkins" has been destroyed. Use option -Xcompressedrefs if you want to destroy a compressed references cache.
11:23:24  JVMSHRC005I No shared class caches available
11:23:24  cache cleanup done
11:23:24  
11:23:24  TESTING:
11:23:25  Directory "/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/../TKG/output_17375630038392/jdk_lang_0/work" not found: creating
11:23:25  Directory "/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/../TKG/output_17375630038392/jdk_lang_0/report" not found: creating
11:23:35  XML output with verification to /home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/output_17375630038392/jdk_lang_0/work
11:23:44  Unhandled exception
11:23:44  Type=Segmentation error vmState=0x00020011
11:23:44  J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000002
11:23:44  Handler1=0000FFFF99835724 Handler2=0000FFFF99E6DA40 InaccessibleAddress=0000FFFF24552978
11:23:44  R0=0000FFFF2455297A R1=0000000048544150 R2=0000FFFF40D6B580 R3=0000FFFEDC00E828
11:23:44  R4=0000000000556500 R5=0000000000000000 R6=0000000000000008 R7=0000000000000000
11:23:44  R8=0101010101010101 R9=0000FFFF40D6B180 R10=0000000000000000 R11=0000FFFF40D6B300
11:23:44  R12=0000000000000030 R13=FFFFFFFFFFFFFFFF R14=0000000000000005 R15=0000FFFF40D6B181
11:23:44  R16=0000FFFF99EC6120 R17=0000FFFF9A13F9C0 R18=0000FFFF40D6B188 R19=0000FFFF40D6B590
11:23:44  R20=0000000000000000 R21=0000FFFF40D6B608 R22=0000FFFF40D6B608 R23=0000FFFEE000F210
11:23:44  R24=0000FFFF40D6B788 R25=0000FFFF9A02CF98 R26=00062C4DEACCE27D R27=0000FFFF9405CAF0
11:23:44  R28=0000FFFF94065518 R29=0000FFFF40D6B510 R30=0000FFFF99856948 R31=0000FFFF40D6B510
11:23:44  PC=0000FFFF998567E8 SP=0000FFFF40D6B510 PSTATE=0000000040001000
11:23:44  V0=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V1=408f400000000000 (f: 0.000000, d: 1.000000e+03)
11:23:44  V2=41cdcd6500000000 (f: 0.000000, d: 1.000000e+09)
11:23:44  V3=2e65746167656c65 (f: 1734700160.000000, d: 3.451214e-85)
11:23:44  V4=637261615f37314b (f: 1597452672.000000, d: 1.109871e+171)
11:23:44  V5=6e6f737265505f78 (f: 1699766144.000000, d: 9.094959e+223)
11:23:44  V6=6f737265505f7875 (f: 1348434048.000000, d: 7.370996e+228)
11:23:44  V7=69746e75722f396a (f: 1915697536.000000, d: 9.774554e+199)
11:23:44  V8=000003c10000745f (f: 29791.000000, d: 2.039238e-311)
11:23:44  V9=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V10=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V11=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V12=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V13=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V14=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V15=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V16=c012f9e393af3c9f (f: 2477735168.000000, d: -4.744032e+00)
11:23:44  V17=6ed9eba16ed9eba1 (f: 1859775360.000000, d: 9.594426e+225)
11:23:44  V18=8f1bbcdc8f1bbcdc (f: 2400959744.000000, d: -6.815449e-236)
11:23:44  V19=ca62c1d6ca62c1d6 (f: 3395469824.000000, d: -2.193092e+50)
11:23:44  V20=0fdd18f2600d3ee4 (f: 1611480832.000000, d: 2.928453e-232)
11:23:44  V21=eb33dd09fee5caca (f: 4276472576.000000, d: -2.550888e+208)
11:23:44  V22=efcdab8967452301 (f: 1732584192.000000, d: -3.598696e+230)
11:23:44  V23=3fa999999999999a (f: 2576980480.000000, d: 5.000000e-02)
11:23:44  V24=3fd6666666666666 (f: 1717986944.000000, d: 3.500000e-01)
11:23:44  V25=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V26=3fb999999999999a (f: 2576980480.000000, d: 1.000000e-01)
11:23:44  V27=000000000000000a (f: 10.000000, d: 4.940656e-323)
11:23:44  V28=0000000000000001 (f: 1.000000, d: 4.940656e-324)
11:23:44  V29=0000000000000000 (f: 0.000000, d: 0.000000e+00)
11:23:44  V30=ffff91d0ffff91c0 (f: 4294939136.000000, d: -nan)
11:23:44  V31=ffff9280ffff9270 (f: 4294939136.000000, d: -nan)
11:23:44  Module=/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/jdkbinary/j2sdk-image/lib/default/libj9vm29.so
11:23:44  Module_base_address=0000FFFF99800000
11:23:44  Target=2_90_20250122_944 (Linux 5.14.0-508.el9.aarch64)
11:23:44  CPU=aarch64 (8 logical CPUs) (0x3d1456000 RAM)
11:23:44  ----------- Stack Backtrace -----------
11:23:44  classHashGetName+0x34 (0x0000FFFF998567E8 [libj9vm29.so+0x567e8])
11:23:44  classHashEqualFn+0x54 (0x0000FFFF99856948 [libj9vm29.so+0x56948])
11:23:44  hashTableRemove+0xb4 (0x0000FFFF9993E474 [libj9vm29.so+0x13e474])
11:23:44  hashClassTableDelete+0x24 (0x0000FFFF99858494 [libj9vm29.so+0x58494])
11:23:44  vmHookAnonClassesUnload+0x3c (0x0000FFFF9984996C [libj9vm29.so+0x4996c])
11:23:44  J9HookDispatch+0x15c (0x0000FFFF99BAF67C [libj9hookable29.so+0x167c])
11:23:44  _ZN21MM_ClassLoaderManager24cleanUpClassLoadersStartEP18MM_EnvironmentBaseP13J9ClassLoaderP10MM_HeapMapP19MM_ClassUnloadStats+0x248 (0x0000FFFF985D7488 [libj9gc29.so+0x1d7488])
11:23:44  _ZN26MM_GlobalCollectorDelegate22unloadDeadClassLoadersEP18MM_EnvironmentBase+0xdc (0x0000FFFF9858B940 [libj9gc29.so+0x18b940])
11:23:44  _ZN26MM_GlobalCollectorDelegate18postMarkProcessingEP18MM_EnvironmentBase+0xb4 (0x0000FFFF9858BAE4 [libj9gc29.so+0x18bae4])
11:23:44  _ZN19MM_ParallelGlobalGC24mainThreadGarbageCollectEP18MM_EnvironmentBaseP22MM_AllocateDescriptionbb+0x118 (0x0000FFFF98542768 [libj9gc29.so+0x142768])
11:23:44  _ZN15MM_ConcurrentGC22internalGarbageCollectEP18MM_EnvironmentBaseP17MM_MemorySubSpaceP22MM_AllocateDescription+0x38 (0x0000FFFF985BD988 [libj9gc29.so+0x1bd988])
11:23:44  _ZN12MM_Collector14garbageCollectEP18MM_EnvironmentBaseP17MM_MemorySubSpaceP22MM_AllocateDescriptionjP28MM_ObjectAllocationInterfaceS3_P20MM_AllocationContext+0xd8 (0x0000FFFF9850319C [libj9gc29.so+0x10319c])
11:23:44  _ZN15MM_ConcurrentGC25concurrentFinalCollectionEP18MM_EnvironmentBaseP17MM_MemorySubSpace+0x114 (0x0000FFFF985C09A4 [libj9gc29.so+0x1c09a4])
11:23:44  _ZN15MM_ConcurrentGC14concurrentMarkEP18MM_EnvironmentBaseP17MM_MemorySubSpaceP22MM_AllocateDescription+0x2a0 (0x0000FFFF985C0FD4 [libj9gc29.so+0x1c0fd4])
11:23:44  _ZN15MM_ConcurrentGC16payAllocationTaxEP18MM_EnvironmentBaseP17MM_MemorySubSpaceS3_P22MM_AllocateDescription+0x74 (0x0000FFFF985C16F4 [libj9gc29.so+0x1c16f4])
11:23:44  _Z21OMR_GC_AllocateObjectP12OMR_VMThreadP25MM_AllocateInitialization+0x1a0 (0x0000FFFF985344F0 [libj9gc29.so+0x1344f0])
11:23:44  J9AllocateObject+0x3b0 (0x0000FFFF984502B0 [libj9gc29.so+0x502b0])
11:23:44  old_slow_jitNewObject+0xa4 (0x0000FFFF990F5544 [libj9jit29.so+0x8f5544])
11:23:44  jitNewObject+0x90 (0x0000FFFF99108458 [libj9jit29.so+0x908458])
11:23:44  ---------------------------------------
11:23:44  JVMDUMP039I Processing dump event "gpf", detail "" at 2025/01/22 16:23:43 - please wait.
11:23:44  JVMDUMP032I JVM requested System dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/output_17375630038392/jdk_lang_0/core.20250122.162343.384824.0001.dmp' in response to an event
11:23:49  JVMDUMP010I System dump written to /home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/output_17375630038392/jdk_lang_0/core.20250122.162343.384824.0001.dmp
11:23:49  JVMDUMP032I JVM requested Java dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/output_17375630038392/jdk_lang_0/javacore.20250122.162343.384824.0002.txt' in response to an event
11:23:49  JVMDUMP010I Java dump written to /home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/output_17375630038392/jdk_lang_0/javacore.20250122.162343.384824.0002.txt
11:23:49  JVMDUMP032I JVM requested Snap dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/output_17375630038392/jdk_lang_0/Snap.20250122.162343.384824.0003.trc' in response to an event
11:23:49  JVMDUMP010I Snap dump written to /home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/output_17375630038392/jdk_lang_0/Snap.20250122.162343.384824.0003.trc
11:23:49  JVMDUMP032I JVM requested JIT dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/output_17375630038392/jdk_lang_0/jitdump.20250122.162343.384824.0004.dmp' in response to an event
11:23:49  JVMDUMP051I JIT dump occurred in 'DefaultTestRunner:Worker-1:1' thread 0x00000000004E3E00
11:23:49  JVMDUMP053I JIT dump is recompiling java/time/LocalDateTime.ofEpochSecond(JILjava/time/ZoneOffset;)Ljava/time/LocalDateTime;
21:22:23  Cancelling nested steps due to timeout
21:22:23  Sending interrupt signal to process
21:22:33  make[4]: *** [autoGen.mk:33: jdk_lang_0] Error 143
21:22:33  make[4]: Leaving directory '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/openjdk'
21:22:33  make[3]: *** [/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG/../TKG/settings.mk:361: testList-openjdk] Error 2
21:22:33  make[3]: Leaving directory '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests'
21:22:33  make[2]: *** [settings.mk:361: testList-..] Error 2
21:22:33  make[2]: Leaving directory '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG'
21:22:33  make[1]: *** [makefile:70: _testList] Error 2
21:22:33  make[1]: Leaving directory '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_aarch64_linux_Personal_testList_0/aqa-tests/TKG'
21:22:33  make: *** [parallelList.mk:8: testList_0] Error 2
21:22:33  script returned exit code 2
[Pipeline] sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajila tajila tajila left review comments

@theresa-m theresa-m theresa-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thallium @tajila @theresa-m