Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:RamClass: Segment allocation enhancements #20896

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

h3110n3rv3
Copy link
Contributor

@h3110n3rv3 h3110n3rv3 commented Jan 9, 2025

The changes reflect the feature request #20644.

Adding segment categories for RAMClass fragments:
sub4G
Frequently accessed
Infrequently accessed

Closes: #20644
Signed-off-by: Nick Kamal <[email protected]>

runtime/oti/j9nonbuilder.h Outdated Show resolved Hide resolved
runtime/oti/j9nonbuilder.h Outdated Show resolved Hide resolved
runtime/vm/createramclass.cpp Outdated Show resolved Hide resolved
@h3110n3rv3 h3110n3rv3 changed the title RamClass: Segment allocation enhancements WIP:RamClass: Segment allocation enhancements Jan 9, 2025
@h3110n3rv3 h3110n3rv3 force-pushed the ramclass-changes branch 2 times, most recently from 8be826c to de5ff00 Compare January 20, 2025 17:16
@h3110n3rv3 h3110n3rv3 requested a review from tajila January 20, 2025 17:26
runtime/vm/createramclass.cpp Outdated Show resolved Hide resolved
runtime/jcl/common/mgmtmemory.c Outdated Show resolved Hide resolved
@@ -2997,17 +3017,18 @@ internalCreateRAMClassFromROMClassImpl(J9VMThread *vmThread, J9ClassLoader *clas
allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].alignment = OMR_MAX(sizeof(J9Class *), sizeof(UDATA));
allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].alignedSize = flattenedClassCacheAllocSize;
allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].address = NULL;
allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].segmentKind = SUB4G;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this sub4g?

The changes reflect the feature request eclipse-openj9#20644.

Adding segment categories for RAMClass fragments:
sub4G
Frequently accessed
Infrequently accessed

Closes: eclipse-openj9#20644
Signed-off-by: Nick Kamal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RamClass: Segment allocation enhancements
2 participants