-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP:RamClass: Segment allocation enhancements #20896
Open
h3110n3rv3
wants to merge
2
commits into
eclipse-openj9:master
Choose a base branch
from
h3110n3rv3:ramclass-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
reviewed
Jan 9, 2025
h3110n3rv3
changed the title
RamClass: Segment allocation enhancements
WIP:RamClass: Segment allocation enhancements
Jan 9, 2025
h3110n3rv3
force-pushed
the
ramclass-changes
branch
2 times, most recently
from
January 20, 2025 17:16
8be826c
to
de5ff00
Compare
h3110n3rv3
force-pushed
the
ramclass-changes
branch
from
January 20, 2025 19:09
161d945
to
7fc2a01
Compare
tajila
reviewed
Jan 22, 2025
tajila
reviewed
Jan 22, 2025
runtime/vm/createramclass.cpp
Outdated
@@ -2997,17 +3017,18 @@ internalCreateRAMClassFromROMClassImpl(J9VMThread *vmThread, J9ClassLoader *clas | |||
allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].alignment = OMR_MAX(sizeof(J9Class *), sizeof(UDATA)); | |||
allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].alignedSize = flattenedClassCacheAllocSize; | |||
allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].address = NULL; | |||
allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].segmentKind = SUB4G; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this sub4g?
The changes reflect the feature request eclipse-openj9#20644. Adding segment categories for RAMClass fragments: sub4G Frequently accessed Infrequently accessed Closes: eclipse-openj9#20644 Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3
force-pushed
the
ramclass-changes
branch
from
January 23, 2025 04:29
f5c2fc7
to
7e93bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes reflect the feature request #20644.
Adding segment categories for RAMClass fragments:
sub4G
Frequently accessed
Infrequently accessed
Closes: #20644
Signed-off-by: Nick Kamal <[email protected]>